Skip to content

fix: create Transformers on demand#90

Merged
ianlewis merged 1 commit intomainfrom
87-bug-folder-transformer-should-be-created-on-each-use
Mar 6, 2025
Merged

fix: create Transformers on demand#90
ianlewis merged 1 commit intomainfrom
87-bug-folder-transformer-should-be-created-on-each-use

Conversation

@ianlewis
Copy link
Owner

@ianlewis ianlewis commented Mar 6, 2025

Description:

Create the folding Transformer via a constructor on demand. A Transformer can hold state so it can't always be reused. It must be re-created each use.

Related Issues:

Fixes #87

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.

@ianlewis ianlewis linked an issue Mar 6, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.09%. Comparing base (a3b74f9) to head (48bcf19).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
stardict.go 86.36% 2 Missing and 1 partial ⚠️
idx/idx.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   40.94%   41.09%   +0.14%     
==========================================
  Files          20       20              
  Lines        1165     1173       +8     
==========================================
+ Hits          477      482       +5     
- Misses        644      646       +2     
- Partials       44       45       +1     
Files with missing lines Coverage Δ
syn/syn.go 40.86% <100.00%> (+1.97%) ⬆️
idx/idx.go 50.00% <85.71%> (+0.84%) ⬆️
stardict.go 43.69% <86.36%> (-0.86%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ianlewis ianlewis force-pushed the 87-bug-folder-transformer-should-be-created-on-each-use branch from 7f12e99 to 9d72352 Compare March 6, 2025 06:33
Signed-off-by: Ian Lewis <ian@ianlewis.org>
@ianlewis ianlewis force-pushed the 87-bug-folder-transformer-should-be-created-on-each-use branch from 9d72352 to 48bcf19 Compare March 6, 2025 06:35
@ianlewis ianlewis merged commit 8dcc59b into main Mar 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Folder transformer should be created on each use

2 participants