fix: Determine the higher version of WeChat browser for Windows

[LLwill]

Description
Now the latest WeChat browser for Windows has used a newer version of Chrome

Issue
Fixes: https://github.com/ianstormtaylor/slate/issues/5912

[12joan]

This is equivalent to !IS_CHROME || IS_CHROME_LEGACY. If that's what you intended, can we replace the condition with this?

Is it possible for the !IS_CHROME case to arise if the user agent contains Wechat (i.e. are there WeChat versions that don't mention Chrome in their user agents)? If not, we can simplify to IS_CHROME_LEGACY.

You said in the PR description:

Now the latest WeChat browser for Windows has used a newer version of Chrome

So it sounds like IS_WECHATBROWSER shouldn't be dependent on IS_CHROME_LEGACY. Do we actually want to rename this constant IS_WECHAT_LEGACY?

[LLwill]

The main concern is that the old version still uses the lower version of the Chrome kernel, so I added a bottom-line judgment. In fact, it is not necessary for the latest version at present.
Now UA:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 NetType/WIFI MicroMessenger/7.0.20.1781(0x6700143B) WindowsWechat(0x63090c33) XWEB/13639 Flue

[12joan]

That makes sense. It sounds like the best thing to do would be to rename the constant to IS_WECHAT_LEGACY to clarify that special behaviour is only needed on the old version, and to simplify the boolean condition.

If the old version's user agent always contains the string Chrome, then && IS_CHROME_LEGACY should be sufficient; no need to check IS_CHROME.

Otherwise, I would recommend && (!IS_CHROME || IS_CHROME_LEGACY).

[LLwill]

You are right, this looks more elegant, I will modify it.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d7b70ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[12joan]

@dylans This was merged without a changeset. One will need to be added before #5917 is merged to ensure slate-dom gets released.