Check if editor is still mounted before trying to focus#5916
Merged
dylans merged 2 commits intoianstormtaylor:mainfrom Jul 10, 2025
Merged
Check if editor is still mounted before trying to focus#5916dylans merged 2 commits intoianstormtaylor:mainfrom
dylans merged 2 commits intoianstormtaylor:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d0c535a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dylans
approved these changes
Jul 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
DOMEditor.focusmethod has a retry mechanism built in. It can happen, that while retrying to focus the dom node of the editor, meanwhile the editor has been unmounted, which will result in an error when callingDOMEditor.toDOMNode(editor, editor).This PR adds a check on top of the
DOMEditor.focusmethod, to check if the editor is still mounted, if not return and do not retry to focus the editor dom node anymore.Issue
Fixes: #5915
Context
This error happened in our unit tests. I guess it's hard to reconstruct in the browser, since it is happening in the milliseconds area.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)