Skip to content

Fix Transforms.wrapNodes where split: true at text node start or end#5943

Merged
dylans merged 2 commits intoianstormtaylor:mainfrom
12joan:fix/wrap-nodes-mark
Aug 25, 2025
Merged

Fix Transforms.wrapNodes where split: true at text node start or end#5943
dylans merged 2 commits intoianstormtaylor:mainfrom
12joan:fix/wrap-nodes-mark

Conversation

@12joan
Copy link
Contributor

@12joan 12joan commented Aug 22, 2025

Description
Previously Transforms.wrapNodes, when called with split: true, did not split at the start or end of the selection correctly if that point was at the start or end of a text node. This could result in adjacent text nodes being inadvertently wrapped.

Issue
Fixes #5942

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@12joan 12joan marked this pull request as draft August 22, 2025 11:30
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 810694e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@12joan 12joan marked this pull request as ready for review August 22, 2025 11:51
@dylans dylans merged commit aaad671 into ianstormtaylor:main Aug 25, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double-clicking word in Firefox selects adjacent nodes

2 participants