Remove immer, making the core slate package dependency-free#5971
Merged
dylans merged 5 commits intoianstormtaylor:mainfrom Nov 21, 2025
Merged
Remove immer, making the core slate package dependency-free#5971dylans merged 5 commits intoianstormtaylor:mainfrom
slate package dependency-free#5971dylans merged 5 commits intoianstormtaylor:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 27e9fee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dylans
approved these changes
Nov 20, 2025
Collaborator
dylans
left a comment
There was a problem hiding this comment.
I guess immer is not really always. 😂
This looks fine to me, going to land another fix to hopefully clean up the failing tests.
This was referenced Nov 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #5871, the only usage of
immerleft is inNode.fragmentfor creating a fragment object. This PR switches it to using the existing non-immer functions.Issue
Mainly decreases bundle size for the
slatepackageFixes #5644 by circumvention, could affect a solution posted for #4111
Context
I couldn't find any actual unit tests for fragments, but manual testing has yielded identical results. If I have the time and patience I might add some next week
also this removes
tiny-warningwhich was entirely unused alreadyChecks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)