Skip to content

Conversation

@smellman
Copy link

@smellman smellman commented Oct 24, 2025

  • support node 24
    • upgrade all dependencies packages
    • added package-lock.json
    • change all code from commonjs to module
    • use static value instead of instance value
  • support current tap command without exit 1 (coverage issue)
    • remove nyc becase current tap command doesn't work with nyc
  • change all Return code to LF and added editorconfig settings (to fix ^M in git diff).
  • added docker support

@ibesora
Copy link
Owner

ibesora commented Oct 25, 2025

Thanks for doing this @smellman.
A couple of questions:

  • Why the change from commonjs to ESM? That makes sense in a Javascript package that you can then import in your project to be able to use tree shaking for example but I'm not sure about the value it brings here.
  • Why the endofline setting change?

@smellman
Copy link
Author

Why the change from commonjs to ESM? That makes sense in a Javascript package that you can then import in your project to be able to use tree shaking for example but I'm not sure about the value it brings here.

chalk v5.x supports only ESM module so I need rewrite all script to ESM module.

Why the endofline setting change?

Some source files use LF while others use CRLF, which causes git diff to show ^M characters.
It was more convenient to unify line endings to LF in .editorconfig, since that prevents escape characters from appearing in git diffs

@ibesora
Copy link
Owner

ibesora commented Oct 28, 2025

This makes sense. Let me review this properly.
And thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants