[DO NOT MERGE][PREVIEW][CS] Aligned codebase with ibexa/code-style#18 #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2025
alongosz
changed the base branch from
main
to
upgrade-to-code-style-2.2.x-dev
alongosz
force-pushed
the
align-with-ibexa-code-style-18
branch
from
070f0fe to
62a2b99
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For now this is a preview of changes needed if run against: current
ibexa/code-style:mainand ibexa/code-style#18, in separate commits, respectively. Can be converted to the actual PR bumping to CS~2.2.0later on.See bc9bd43 and 070f0fe for the changes resulting from ibexa/code-style#18. Strangely, while no FQCN in PHPDoc rule is available in
2.2.x-dev(ibexa/code-style@62c1a78), in some cases it kicked in due tofully_qualified_strict_typesafter bumping CS Fixer to v3.89.0 (at least this is what I suspect to be the cause, as the rule was there before).There are two difference which stand out after applying ibexa/code-style#18:
modifier_keywordsreplacingvisibility_required. Seems to me it works in our favor, adding missingpublickeywords toreadonlydefinitions. At least I think that was the intention.single_line_empty_bodyyields some more changes (070f0fe) after PHP CS Fixer bump.Files changed with ibexa/code-style#18: