Moved ClientNotConfiguredException to contracts#30
Merged
konradoboza merged 1 commit intomainfrom Aug 27, 2025
Merged
Conversation
konradoboza
added
Doc needed
|
wiewiurdp
approved these changes
Aug 26, 2025
tbialcz
approved these changes
Aug 27, 2025
adamwojs
approved these changes
Aug 27, 2025
konradoboza
deleted the
moved-client-not-configured-exception-to-contracts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
For Doc Team
Once we accept this change we need to adjust the mentioned example and regenerate Deptrac baseline by removing the entry named below.
Description:
This seems to be a low-hanging fruit - it will resolve Deptrac issue reported in this example:
https://doc.ibexa.co/en/latest/multisite/languages/automated_translations/#add-a-custom-machine-translation-service
https://github.com/ibexa/documentation-developer/blob/add-deptrac/deptrac.baseline.yaml#L23-L24
Since it targets
mainI would say it shouldn't be harmful. On the occasion of this PR I fixed some outstanding issues I spotted along the way.Documentation: