IBX-11179: Updated PHP versions in CI configuration with 8.3 and 8.4#724
Merged
IBX-11179: Updated PHP versions in CI configuration with 8.3 and 8.4#724
Conversation
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
3 times, most recently
from
13059dd to
d459d33
Compare
Steveb-p
reviewed
Mar 6, 2026
| fwrite($tmpFile, $binary->getContent()); | ||
| $tmpMetadata = stream_get_meta_data($tmpFile); | ||
| $binaryCreateStruct = $this->ioService->newBinaryCreateStructFromLocalFile($tmpMetadata['uri']); | ||
| // @phpstan-ignore-next-line |
Contributor
There was a problem hiding this comment.
Inline PHPStan ignores are by default forbidden, unless you have a valid reason to do so (for example, if you're explicitly testing an invalid combination).
Put these in baseline instead, in lieu of providing a fix.
Steveb-p
requested changes
Mar 6, 2026
Contributor
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
I don't agree with how a lot of try...catch blocks are transformed to catch all throwables. Why?
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
konradoboza
reviewed
Mar 9, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Majority of changes are out of scope. Please narrow down only the code that needs to be fixed to work with PHP8.4.
konradoboza
reviewed
Mar 9, 2026
Contributor
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Please remember that touching the production code which doesn't need to be changed to provide PHP8.4 compatibility comes with a cost of potential QA. Let's make sure the diff is minimal, we can reduce baseline in the future.
tests/bundle/Core/DependencyInjection/Configuration/Parser/LanguagesTest.php
Outdated
Show resolved
Hide resolved
tests/bundle/Core/EventListener/BackgroundIndexingTerminateListenerTest.php
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Templating/Twig/Extension/FileSystemTwigIntegrationTestCase.php
Outdated
Show resolved
Hide resolved
tests/lib/Persistence/Cache/Adapter/InMemoryClearingProxyAdapterTest.php
Show resolved
Hide resolved
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
3 times, most recently
from
9ec539e to
e2a499d
Compare
added 4 commits
March 10, 2026 12:37
…mports, and updated phpstan baseline entries.
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
from
e2a499d to
7dcba4a
Compare
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
from
7dcba4a to
0529031
Compare
konradoboza
reviewed
Mar 10, 2026
tests/lib/MVC/Symfony/Templating/Twig/Extension/FileSystemTwigIntegrationTestCase.php
Outdated
Show resolved
Hide resolved
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
from
484788a to
7328397
Compare
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification
branch
from
7328397 to
38b9683
Compare
|
konradoboza
approved these changes
Mar 11, 2026
alongosz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updated PHP versions in CI configuration with 8.3 and 8.4