Skip to content

Refactor: Removed toString type casting from template literals#56

Merged
dew326 merged 1 commit intomainfrom
refactor-type-casting
Oct 21, 2025
Merged

Refactor: Removed toString type casting from template literals#56
dew326 merged 1 commit intomainfrom
refactor-type-casting

Conversation

@albozek
Copy link
Copy Markdown
Contributor

@albozek albozek commented Oct 20, 2025

🎫 Issue IBX-XXXXX

Related PRs:

Description:

For QA:

Documentation:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors template literal usages by removing unnecessary explicit toString() calls.

  • Removed redundant toString() inside template literals in input text padding and accordion height calculations.
  • Simplified badge value formatting for max value case; remaining branch still uses toString().

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/bundle/Resources/public/ts/components/input_text/input_text_input.ts Removed unnecessary toString() in template literal for padding style.
src/bundle/Resources/public/ts/components/accordion.ts Removed unnecessary toString() in template literal for height transitions.
src/bundle/Resources/public/ts/components/Badge.ts Partially removed redundant toString(); inconsistency remains in value formatting.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@albozek albozek force-pushed the refactor-type-casting branch from 3b2be14 to 7c685c6 Compare October 21, 2025 12:41
@dew326 dew326 merged commit c942efd into main Oct 21, 2025
5 checks passed
@dew326 dew326 deleted the refactor-type-casting branch October 21, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants