Refactor: Removed toString type casting from template literals#56
Merged
Refactor: Removed toString type casting from template literals#56
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors template literal usages by removing unnecessary explicit toString() calls.
- Removed redundant toString() inside template literals in input text padding and accordion height calculations.
- Simplified badge value formatting for max value case; remaining branch still uses toString().
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bundle/Resources/public/ts/components/input_text/input_text_input.ts | Removed unnecessary toString() in template literal for padding style. |
| src/bundle/Resources/public/ts/components/accordion.ts | Removed unnecessary toString() in template literal for height transitions. |
| src/bundle/Resources/public/ts/components/Badge.ts | Partially removed redundant toString(); inconsistency remains in value formatting. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dew326
approved these changes
Oct 20, 2025
alekmick
approved these changes
Oct 20, 2025
GrabowskiM
approved these changes
Oct 20, 2025
3b2be14 to
7c685c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: