Conversation
This was referenced Oct 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Chip component to the design system, implementing a closable UI element with error and disabled states. The component follows the Twig Component architecture with server-side validation and client-side event handling.
Key Changes:
- Added
ChipPHP component with configurableerror,isClosable, anddisabledproperties - Implemented Twig template with conditional styling and close button
- Created TypeScript class for handling close button interactions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/lib/Twig/Components/Chip.php |
Defines the Chip component class with property validation using OptionsResolver |
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig |
Provides the HTML structure with conditional classes and close button rendering |
src/bundle/Resources/public/ts/components/chip.ts |
Implements client-side logic for close button event handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GrabowskiM
requested changes
Oct 21, 2025
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig
Outdated
Show resolved
Hide resolved
ce32b2f to
e6058a6
Compare
GrabowskiM
requested changes
Oct 22, 2025
GrabowskiM
approved these changes
Oct 23, 2025
dew326
approved these changes
Oct 24, 2025
alekmick
approved these changes
Oct 27, 2025
konradoboza
approved these changes
Oct 27, 2025
mikadamczyk
reviewed
Oct 27, 2025
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig
Outdated
Show resolved
Hide resolved
mikadamczyk
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: