Skip to content

IBX-7899: Chip component#57

Merged
dew326 merged 9 commits intomainfrom
IBX-7899
Oct 27, 2025
Merged

IBX-7899: Chip component#57
dew326 merged 9 commits intomainfrom
IBX-7899

Conversation

@albozek
Copy link
Copy Markdown
Contributor

@albozek albozek commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Chip component to the design system, implementing a closable UI element with error and disabled states. The component follows the Twig Component architecture with server-side validation and client-side event handling.

Key Changes:

  • Added Chip PHP component with configurable error, isClosable, and disabled properties
  • Implemented Twig template with conditional styling and close button
  • Created TypeScript class for handling close button interactions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/lib/Twig/Components/Chip.php Defines the Chip component class with property validation using OptionsResolver
src/bundle/Resources/views/themes/standard/design_system/components/chip.html.twig Provides the HTML structure with conditional classes and close button rendering
src/bundle/Resources/public/ts/components/chip.ts Implements client-side logic for close button event handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@albozek albozek force-pushed the IBX-7899 branch 2 times, most recently from ce32b2f to e6058a6 Compare October 21, 2025 13:39
@albozek albozek requested a review from GrabowskiM October 21, 2025 13:52
@albozek albozek requested a review from GrabowskiM October 22, 2025 12:59
@albozek albozek requested a review from mikadamczyk October 23, 2025 13:40
@mikadamczyk mikadamczyk requested a review from a team October 27, 2025 07:57
@dew326 dew326 merged commit 8ec621c into main Oct 27, 2025
5 checks passed
@dew326 dew326 deleted the IBX-7899 branch October 27, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants