Fixed charset on SQL dump from YAML schema #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid having "DEFAULT CHARACTER SET utf8 COLLATE `utf8_unicode_ci`" from https://github.com/doctrine/dbal/blob/3.10.x/src/Platforms/AbstractMySQLPlatform.php#L579-L600 when using `ibexa:doctrine:schema:dump-sql` on files like https://github.com/ibexa/oauth2-server/blob/main/src/bundle/Resources/config/schema.yaml or https://github.com/ibexa/shopping-list/blob/main/src/bundle/Resources/config/schema.yaml
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Inject the default table options into the schema imported from file.
It avoids having
DEFAULT CHARACTER SET utf8 COLLATE `utf8_unicode_ci`from https://github.com/doctrine/dbal/blob/3.10.x/src/Platforms/AbstractMySQLPlatform.php#L579-L600 when usingibexa:doctrine:schema:dump-sqlon files like https://github.com/ibexa/oauth2-server/blob/main/src/bundle/Resources/config/schema.yaml or https://github.com/ibexa/shopping-list/blob/main/src/bundle/Resources/config/schema.yamlNotice that it might disappear by itself if we move to doctrine/dbal 4 as there is no hardcoded charset in https://github.com/doctrine/dbal/blob/4.4.x/src/Platforms/AbstractMySQLPlatform.php#L331-L337
For QA:
Documentation: