-
Notifications
You must be signed in to change notification settings - Fork 81
Reorganize "Update and migration" #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to_3.3.latest.md is outdated and duplicates the more-up-to-date update_from_3.3.md
vidarl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
There is one flaw in the upgrade doc that should also be addressed.
In thecomposer updatecommand, we always refer to the latest maintenance release. ie like here we ATM refer to 4.6.12 -
Then we later run migrations
-
And after that we run schema updates like for 4.6.4
Step 2 might fail since code may require the schema changes that are applied later
So, once you upgrade to latest maintenance release, the next step should always be to get schema up2date.. Then run remaining upgrade scripts in correct order
(Note: this issue was already there and not inserted by this reorganization.) I see no quick easy fix for that. Because of migration changes in 4.6.2 in https://github.com/ibexa/dashboard/commit/f2f220b101a97ce2232325a7c42acf26be7f9efc and https://github.com/ibexa/installer/blob/4.6/upgrade/db/mysql/ibexa-4.6.1-to-4.6.2.sql we can't propose to move to 4.6.0, execute migrations, and then upgrade to 4.6.latest, and run the database update. |
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much clearer, thank you! I agree that we can further improve this in a follow-up.
Good job spotting and deleting the outdated instructions for 3.3
Co-authored-by: Marek Nocoń <[email protected]>
I didn't propose that either. Upgrading code to latest 4.6.x is better ( and less work than go through 4.6.0 first). Ok, I am fine about addressing this later. But it should be addressed at some point |
--------- Co-authored-by: Marek Nocoń <[email protected]> (cherry picked from commit ac53a56)
--------- Co-authored-by: Marek Nocoń <[email protected]> (cherry picked from commit ac53a56)
Side-note(s) about unsolved issues in this batch
Checklist