Skip to content

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Oct 11, 2024

Question Answer
JIRA Ticket IBX-9082
Versions All
Edition All

Side-note(s) about unsolved issues in this batch

  • File names (and, so, URLs) could better express the contents.
  • IBX-9082 created to not forget to continue.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis marked this pull request as ready for review October 14, 2024 10:25
@adriendupuis adriendupuis requested a review from vidarl October 14, 2024 10:26
Copy link
Contributor

@vidarl vidarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is one flaw in the upgrade doc that should also be addressed.
    In the composer update command, we always refer to the latest maintenance release. ie like here we ATM refer to 4.6.12

  2. Then we later run migrations

  3. And after that we run schema updates like for 4.6.4

Step 2 might fail since code may require the schema changes that are applied later

So, once you upgrade to latest maintenance release, the next step should always be to get schema up2date.. Then run remaining upgrade scripts in correct order

@adriendupuis
Copy link
Contributor Author

adriendupuis commented Oct 15, 2024

  1. There is one flaw in the upgrade doc that should also be addressed.
    In the composer update command, we always refer to the latest maintenance release. ie like here we ATM refer to 4.6.12

Step 2 might fail since code may require the schema changes that are applied later

So, once you upgrade to latest maintenance release, the next step should always be to get schema up2date.. Then run remaining upgrade scripts in correct order

(Note: this issue was already there and not inserted by this reorganization.)

I see no quick easy fix for that. Because of migration changes in 4.6.2 in https://github.com/ibexa/dashboard/commit/f2f220b101a97ce2232325a7c42acf26be7f9efc and https://github.com/ibexa/installer/blob/4.6/upgrade/db/mysql/ibexa-4.6.1-to-4.6.2.sql we can't propose to move to 4.6.0, execute migrations, and then upgrade to 4.6.latest, and run the database update.

@vidarl I'm adding this issue to IBX-9082 for later.

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much clearer, thank you! I agree that we can further improve this in a follow-up.

Good job spotting and deleting the outdated instructions for 3.3

@vidarl
Copy link
Contributor

vidarl commented Oct 18, 2024

we can't propose to move to 4.6.0, execute migrations, and then upgrade to 4.6.latest, and run the database update.

I didn't propose that either. Upgrading code to latest 4.6.x is better ( and less work than go through 4.6.0 first).
I am just saying than upgrading schema should be the next step, not running migrations or other php scripts that might fail due to not-up2date-schema ...

@vidarl I'm adding this issue to IBX-9082 for later.

Ok, I am fine about addressing this later. But it should be addressed at some point

@vidarl vidarl self-requested a review October 18, 2024 10:33
@adriendupuis adriendupuis merged commit ac53a56 into master Oct 18, 2024
5 of 6 checks passed
@adriendupuis adriendupuis deleted the reorganize-update_and_migration branch October 18, 2024 16:43
adriendupuis added a commit that referenced this pull request Oct 18, 2024
---------

Co-authored-by: Marek Nocoń <[email protected]>
(cherry picked from commit ac53a56)
adriendupuis added a commit that referenced this pull request Oct 18, 2024
---------

Co-authored-by: Marek Nocoń <[email protected]>

(cherry picked from commit ac53a56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants