IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 #2525

julitafalcondusza · 2024-10-24T12:57:29Z

Question	Answer
JIRA Ticket	(https://issues.ibexa.co/browse/IBX-9147)
Versions	4.6+

Symbol attribute type described in Developer Documentation - v4.6

Preview:

Checklist

Text renders correctly
Text has been checked with vale
Description metadata is up to date
Code samples are working
PHP code samples have been fixed with PHP CS fixer
Added link to this PR in relevant JIRA ticket or code PR

mnocon

Thank you for preparing this!

I've left a couple of suggestions to make it clearer - but I believe it already includes all the neccessary parts, we just need to improve them a bit.

I cannot provide you with the PostgreSQL schema, we will need someone from the backend team for that.

docs/pim/symbol_attribute_type.md

docs/search/criteria_reference/symbolattribute_criterion.md

docs/pim/symbol_attribute_type.md

adamwojs · 2024-10-25T15:01:51Z

I cannot provide you with the PostgreSQL schema, we will need someone from the backend team for that.

I will take care of it.

github-actions · 2025-07-09T11:15:18Z

Preview of modified files

Preview of modified Markdown:

mnocon

Looks good overall, just a couple of comments to improve this.

Please remember to create a PR to the user doc, mentioning this attribute (just a mention is ok, we did the same for date and time: https://doc.ibexa.co/projects/userguide/en/latest/pim/work_with_product_attributes/ )

Also, please have a look at the read the docs error - I think we (I) have lost the mkdocs.yml modification during conflict resolution, could you please readd the symbolattribute_criterion.md file to make the build pass?

docs/pim/symbol_attribute_type.md

docs/search/criteria_reference/symbolattribute_criterion.md

docs/pim/attributes/symbol_attribute_type.md

docs/search/criteria_reference/symbolattribute_criterion.md

mnocon · 2025-07-15T08:01:18Z

Another thing which I forgot about: please add the new LTS update to the table of LTS updates (https://github.com/ibexa/documentation-developer/blob/4.6/docs/ibexa_products/editions.md#lts-updates)

…- v4.6 (#2525) * Symbol attribute type described * Fixes after review * PHP CS Fixes * Resolved conflicts in product search criteria * Added composer dependency * fixes * review fixes * PHP & JS CS Fixes * symbol_attribute_type.md moved to Attributes folder * fixes; mysql added * fix in the table * fix --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Marek Nocoń <[email protected]>

* Added new Twig Component group (#2790) * Twig Component follow ups (#2792) * Added Priority for YAML configuration * Added doc for storefront groups * Adjusted paths * Update docs/templating/layout/customize_storefront_layout.md Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: julitafalcondusza <[email protected]> * [Twig Components] Added Menu component (#2799) * Docs: Add Menu component to Twig Components documentation * Docs: Extend Twig Components YAML example with Menu component * Discounts 4.6.22 (#2810) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix --------- Co-authored-by: Konrad Oboza <[email protected]> * IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 (#2525) * Symbol attribute type described * Fixes after review * PHP CS Fixes * Resolved conflicts in product search criteria * Added composer dependency * fixes * review fixes * PHP & JS CS Fixes * symbol_attribute_type.md moved to Attributes folder * fixes; mysql added * fix in the table * fix --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Marek Nocoń <[email protected]> * Update 4.6.22 (#2851) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix * Added doc for IBX-9933 * Fixed badge --------- Co-authored-by: Konrad Oboza <[email protected]> * IBX-9845: Solr9 (#2866) * Adjusted code samples * [Discounts] Added doc for 4.6.22 * Fixed limit mention * Added update mention * Removed mentions of OverridePrioritatization * Wording * Update code_samples/discounts/src/Command/ManageDiscountsCommand.php Co-authored-by: Konrad Oboza <[email protected]> * Fixed highlights * Review suggestions * Added missing v prefix * Described requirements * Added Solr 9 instructions * Fixed link * Updated instructions * Apply suggestions from code review Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: Konrad Oboza <[email protected]> Co-authored-by: julitafalcondusza <[email protected]> * Release notes (#2869) * IBX-10262: Added mention of the renamed class * Release notes for 4.6.22 * Apply suggestions from code review Co-authored-by: julitafalcondusza <[email protected]> * Review fixes * Fixed link * Last minute fixes --------- Co-authored-by: julitafalcondusza <[email protected]> * Regenerated baseline * Removed bullet * Bumped latest tag * Added PHP API links * Added mention about Symbol attribute * Fixed link * Moved PHP API Symbol links * symbol_attribute_type.md: Link to PHP API Ref --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Konrad Oboza <[email protected]> Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Adrien Dupuis <[email protected]>

mnocon reviewed Oct 24, 2024

View reviewed changes

julitafalcondusza force-pushed the IBX-9147 branch from 9685412 to 2bc62c6 Compare October 29, 2024 14:09

mnocon changed the base branch from master to 5.0 May 19, 2025 07:33

adamwojs approved these changes Jul 8, 2025

View reviewed changes

julitafalcondusza changed the base branch from 5.0 to 4.6 July 9, 2025 09:27

julitafalcondusza and others added 4 commits July 9, 2025 12:46

Symbol attribute type described

0ff312b

Fixes after review

60fdb8b

PHP CS Fixes

b037ab1

Resolved conflicts in product search criteria

528bf4e

mnocon force-pushed the IBX-9147 branch from 2bc62c6 to 528bf4e Compare July 9, 2025 11:07

julitafalcondusza marked this pull request as ready for review July 9, 2025 11:09

julitafalcondusza added the Needs DOC review label Jul 9, 2025

julitafalcondusza requested a review from mnocon July 9, 2025 11:09

Added composer dependency

4dec593

mnocon reviewed Jul 9, 2025

View reviewed changes

julitafalcondusza and others added 3 commits July 10, 2025 11:34

fixes

4db77ba

review fixes

dc91ecb

PHP & JS CS Fixes

c83c9a2

julitafalcondusza requested a review from mnocon July 15, 2025 06:17

julitafalcondusza changed the title ~~IBX-9147: Symbol attribute type described in Developer Documentation~~ IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 Jul 15, 2025

symbol_attribute_type.md moved to Attributes folder

a7f9a21

mnocon reviewed Jul 15, 2025

View reviewed changes

docs/pim/attributes/symbol_attribute_type.md Outdated Show resolved Hide resolved

docs/search/criteria_reference/symbolattribute_criterion.md Outdated Show resolved Hide resolved

julitafalcondusza added 3 commits July 15, 2025 12:27

fixes; mysql added

a139c9c

fix in the table

eb06677

fix

2115481

julitafalcondusza requested a review from mnocon July 16, 2025 10:21

mnocon approved these changes Jul 16, 2025

View reviewed changes

julitafalcondusza added Wait with merge PRs that shouldn't be merged instantly and removed Needs DOC review labels Jul 17, 2025

mnocon mentioned this pull request Jul 17, 2025

Procedure to update from 4.6 to 5.0 #2760

Merged

7 tasks

mnocon changed the base branch from 4.6 to release-4.6.22 August 5, 2025 11:33

mnocon mentioned this pull request Aug 5, 2025

Release 4.6.22 #2867

Merged

mnocon merged commit 27f0e56 into release-4.6.22 Aug 5, 2025
8 checks passed

mnocon deleted the IBX-9147 branch August 5, 2025 11:34

IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 #2525

IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 #2525

Uh oh!

Conversation

julitafalcondusza commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

mnocon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamwojs commented Oct 25, 2024

Uh oh!

github-actions bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview of modified files

Uh oh!

mnocon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnocon commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

julitafalcondusza commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2025 •

edited

Loading