Skip to content

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Oct 29, 2024

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-9006)
Versions 4.6+

Before merging, please test as a doc review.

Collaborative editing - REST API documentation:
Doc preview: https://ez-systems-developer-documentation--2528.com.readthedocs.build/en/2528/api/rest_api/rest_api_reference/rest_api_reference.html#collaborative-editing

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@juskora juskora force-pushed the IBX-9006 branch 2 times, most recently from 9869bdb to b51e407 Compare November 18, 2024 08:42
@juskora juskora requested a review from ciastektk November 18, 2024 08:42
@juskora juskora marked this pull request as ready for review November 19, 2024 11:30
Copy link

github-actions bot commented Apr 2, 2025

Preview of modified Markdown: no Markdown change to preview.

@mnocon mnocon changed the base branch from master to 5.0 May 19, 2025 07:33
@juskora juskora changed the base branch from 5.0 to 4.6 August 29, 2025 07:22
@juskora juskora changed the base branch from 4.6 to 5.0 August 29, 2025 07:23
@juskora juskora changed the base branch from 5.0 to 4.6 September 1, 2025 07:58
@mnocon mnocon changed the base branch from 4.6 to 5.0 September 1, 2025 09:37
@mnocon mnocon changed the base branch from 5.0 to 4.6 September 1, 2025 09:48
Copy link

github-actions bot commented Sep 1, 2025

Preview of modified files: no change to preview.

Copy link
Contributor

@ciastektk ciastektk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect responses for internal participant update

@ciastektk
Copy link
Contributor

Missing section about session updates:

Method: PATCH

{
    "ContentSessionUpdate": {
        "hasPublicLink": true
    }
}
<?xml version="1.0" encoding="UTF-8"?>
<ContentSessionUpdate>
    <hasPublicLink>true</hasPublicLink>
</ContentSessionUpdate>

@juskora juskora requested a review from ciastektk September 23, 2025 06:53
Comment on lines 110 to 114
<<<<<<< HEAD
/{sessionToken}/participants:
=======
/{sessionId}/participants:
>>>>>>> 4b9d881fa945112fde19d619e21bd8be8c3884ba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that diffs from conflict resolving is added here and below.

description: Error - no session with the given ID exists.
=======
description: Error - no session with the given ID exists.
/{sessionId}/link:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned, this is internal endpoint and it should not be presented.

@julitafalcondusza
Copy link
Contributor Author

Checked and approved from my side (cannot approve as I'm the author of the PR) ✅

@julitafalcondusza julitafalcondusza merged commit b72713f into 4.6 Oct 2, 2025
6 of 7 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-9006 branch October 2, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants