Skip to content

Conversation

@mnocon
Copy link
Contributor

@mnocon mnocon commented Nov 28, 2024

Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about wordings, otherwise good.

@mnocon mnocon added the Wait with merge PRs that shouldn't be merged instantly label Nov 28, 2024
@mnocon mnocon changed the title Update 4.6.14 3.3.41 Update foc for 4.6.14 and 3.3.41 Nov 28, 2024
@mnocon mnocon changed the title Update foc for 4.6.14 and 3.3.41 Update doc for 4.6.14 and 3.3.41 Nov 28, 2024
@arfaram
Copy link
Contributor

arfaram commented Nov 28, 2024

@mnocon btw. I think this PR should also be mentioned in the release doc (Apache/Nginx changes) ibexa/post-install@1bf4267

@mnocon
Copy link
Contributor Author

mnocon commented Nov 28, 2024

@adriendupuis @arfaram I've applied your suggestions in 0322d98 , thank you!

Update your Varnish VCL file to align it with the [`vendor/ezsystems/ezplatform-http-cache/docs/varnish/vcl/varnish7.vcl`](https://github.com/ezsystems/ezplatform-http-cache/blob/2.3/docs/varnish/vcl/varnish7.vcl) file.
```

If you're not using a reverse proxy like Varnish or Fastly, adjust the compressed Content Type in the web server configuration.
Copy link
Contributor

@adriendupuis adriendupuis Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's the HTTP header, maybe we could show it as code-like?

Suggested change
If you're not using a reverse proxy like Varnish or Fastly, adjust the compressed Content Type in the web server configuration.
If you're not using a reverse proxy like Varnish or Fastly, adjust the compressed `Content-Type` in the web server configuration.

@mnocon mnocon merged commit d5eabd9 into master Nov 28, 2024
6 checks passed
@mnocon mnocon deleted the update-4.6.14-3.3.41 branch November 28, 2024 16:10
mnocon added a commit that referenced this pull request Nov 28, 2024
* Updated 3.3 and 4.6 release variables

* Added update instructions

* Fixed headings

* Formatting fixes

* Added mention about Apache and Nginx

* Heading changes

* Fixed Varnish link

* Reworded lack of update steps

* Update docs/update_and_migration/from_3.3/update_from_3.3.md

Co-authored-by: Adrien Dupuis <[email protected]>

* Review: added BREACH explanantion and mentioned another webserver template change

* Apply suggestions from code review

Co-authored-by: Tomasz Dąbrowski <[email protected]>

* Applied review suggestions and added advisory links

* Fixed typo

* Review fixes - Content-Type, EOL space, command descripition fixed for 4.6

* Command fixes

---------

Co-authored-by: Adrien Dupuis <[email protected]>
Co-authored-by: Tomasz Dąbrowski <[email protected]>
mnocon added a commit that referenced this pull request Nov 28, 2024
* Updated 3.3 and 4.6 release variables

* Added update instructions

* Fixed headings

* Formatting fixes

* Added mention about Apache and Nginx

* Heading changes

* Fixed Varnish link

* Reworded lack of update steps

* Update docs/update_and_migration/from_3.3/update_from_3.3.md

Co-authored-by: Adrien Dupuis <[email protected]>

* Review: added BREACH explanantion and mentioned another webserver template change

* Apply suggestions from code review

Co-authored-by: Tomasz Dąbrowski <[email protected]>

* Applied review suggestions and added advisory links

* Fixed typo

* Review fixes - Content-Type, EOL space, command descripition fixed for 4.6

* Command fixes

---------

Co-authored-by: Adrien Dupuis <[email protected]>
Co-authored-by: Tomasz Dąbrowski <[email protected]>
@mnocon mnocon removed Wait with merge PRs that shouldn't be merged instantly Needs DOC review labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants