Skip to content

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 2, 2024

Question Answer
JIRA Ticket IBX-4064
Versions All
Edition All
  • "See all results" → "See more results" Algolia is limited to 1000 results. As I didn't find a way to increase it, the need was discarded as nobody goes to the 1000th result. "See more results" is more adapted to this situation of not showing absolutely all results.
  • Disable keyboard selection, no more result highlight moving on keyboard navigation with arrows. To navigate with keyboard doesn't work as "Enter" key is a shortcut to open the search page instead of the item selected with the keyboard, so, highlight was useless and misleading.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis marked this pull request as ready for review December 4, 2024 16:19
adriendupuis added a commit to ibexa/documentation-user that referenced this pull request Dec 4, 2024
Copy link
Contributor

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have an issue with "Show more results" link. Contacted Adrien directly with a recording

@dabrt dabrt self-requested a review December 5, 2024 08:13
@adriendupuis
Copy link
Contributor Author

adriendupuis commented Dec 5, 2024

I seem to have an issue with "Show more results" link. Contacted Adrien directly with a recording

The "See more results" link appears only when there is more than 10 results. If all the results are in the drop-down list, no need to link to a search result screen which pagination will only present one page.

But, it's true that seeing the link blinking while typing could be disturbing. It's worth thinking more about this (a placeholder, an idle delay, …)

@adriendupuis adriendupuis merged commit 33fc6d9 into master Dec 5, 2024
6 checks passed
@adriendupuis adriendupuis deleted the search-fix branch December 5, 2024 09:13
adriendupuis added a commit that referenced this pull request Dec 5, 2024
* custom.js: "See all results" → "See more results"
* custom.js: No search result highlight on keyboard navigation

(cherry picked from commit 33fc6d9)
adriendupuis added a commit that referenced this pull request Dec 5, 2024
* custom.js: "See all results" → "See more results"
* custom.js: No search result highlight on keyboard navigation

(cherry picked from commit 33fc6d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants