Skip to content

[v5] Moved from Criterion to CriterionInterface #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[v5] Moved from Criterion to CriterionInterface #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e59b8f
[v5] Moved from Criterion to CriterionInterface
mnocon Dec 10, 2024
03bd73e
Added PHPdoc
mnocon Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...ples/search/elasticsearch/src/Query/Criterion/Elasticsearch/CameraManufacturerVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,21 @@

namespace App\Query\Criterion\Elasticsearch;

use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
use Ibexa\Contracts\Core\Repository\Values\Content\Query\CriterionInterface;
use Ibexa\Contracts\Elasticsearch\Query\CriterionVisitor;
use Ibexa\Contracts\Elasticsearch\Query\LanguageFilter;

final class CameraManufacturerVisitor implements CriterionVisitor
{
public function supports(Criterion $criterion, LanguageFilter $languageFilter): bool
public function supports(CriterionInterface $criterion, LanguageFilter $languageFilter): bool
{
return $criterion instanceof CameraManufacturerCriterion;
}

public function visit(CriterionVisitor $dispatcher, Criterion $criterion, LanguageFilter $languageFilter): array
/**
* @param \App\Query\Criterion\Elasticsearch\CameraManufacturerCriterion $criterion
*/
public function visit(CriterionVisitor $dispatcher, CriterionInterface $criterion, LanguageFilter $languageFilter): array
{
return [
'terms' => [
Expand Down
9 changes: 6 additions & 3 deletions code_samples/search/solr/src/Query/Criterion/Solr/CameraManufacturerVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,20 @@

namespace App\Query\Criterion\Solr;

use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
use Ibexa\Contracts\Core\Repository\Values\Content\Query\CriterionInterface;
use Ibexa\Contracts\Solr\Query\CriterionVisitor;

final class CameraManufacturerVisitor extends CriterionVisitor
{
public function canVisit(Criterion $criterion)
public function canVisit(CriterionInterface $criterion)
{
return $criterion instanceof CameraManufacturerCriterion;
}

public function visit(Criterion $criterion, CriterionVisitor $subVisitor = null)
/**
* @param \App\Query\Criterion\Solr\CameraManufacturerCriterion $criterion
*/
public function visit(CriterionInterface $criterion, CriterionVisitor $subVisitor = null)
{
$expressions = array_map(
function ($value): string {
Expand Down
Loading