-
Notifications
You must be signed in to change notification settings - Fork 81
IBX-9369: GET orders/orders?limit&offet #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for covering this!
If I understand the code from https://github.com/ibexa/order-management/pull/136/files correctly, there's also a totalCount (or count) property, shouldn't we update the response example?
@mnocon I added it. We still have to wait for 4.6.17 |
|
Preview of modified Markdown: no Markdown change to preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
I'm sorry, I keep having ideas after initial reviews today:
|
@mnocon It's already there, directly for XML, wrapped for JSON. |
|
@adriendupuis I mean that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!

Document
orders/ordersnewlimitandoffsetGET parameters for pagination.PREVIEW
TODO: Wait for this feature being released in next 4.6.xreleased in 4.6.17Checklist