Skip to content

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Jan 21, 2025

Question Answer
JIRA Ticket IBX-9369
Versions 4.6.?
Edition Commerce

Document orders/orders new limit and offset GET parameters for pagination.

PREVIEW

TODO: Wait for this feature being released in next 4.6.x released in 4.6.17

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis added the Wait with merge PRs that shouldn't be merged instantly label Jan 21, 2025
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for covering this!

If I understand the code from https://github.com/ibexa/order-management/pull/136/files correctly, there's also a totalCount (or count) property, shouldn't we update the response example?

@adriendupuis
Copy link
Contributor Author

If I understand the code from https://github.com/ibexa/order-management/pull/136/files correctly, there's also a totalCount (or count) property, shouldn't we update the response example?

@mnocon I added it.

We still have to wait for 4.6.17

@github-actions
Copy link

Preview of modified Markdown: no Markdown change to preview.

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mnocon mnocon self-requested a review February 20, 2025 12:28
@mnocon
Copy link
Contributor

mnocon commented Feb 20, 2025

I'm sorry, I keep having ideas after initial reviews today:

@adriendupuis
Copy link
Contributor Author

adriendupuis commented Feb 21, 2025

I'm sorry, I keep having ideas after initial reviews today:

@mnocon It's already there, directly for XML, wrapped for JSON.
image
Did I misunderstood?

@mnocon
Copy link
Contributor

mnocon commented Feb 21, 2025

@adriendupuis I mean that the count property should be added to the OrderList type (it's not listed in https://github.com/ibexa/documentation-developer/blob/IBX-9369-rest-orders-pagination/docs/api/rest_api/rest_api_reference/input/ibexa-types.raml#L5209-L5214)

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriendupuis adriendupuis merged commit a2c739d into master Mar 5, 2025
6 of 7 checks passed
@adriendupuis adriendupuis deleted the IBX-9369-rest-orders-pagination branch March 5, 2025 08:09
adriendupuis added a commit that referenced this pull request Mar 5, 2025
* ibexa-orders.raml: GET orders/orders?limit&offset
* OrderList.json.example: Add count
* ibexa-types.raml: Add count to OrderList
* Regenerate REST API Ref HTML

(cherry picked from commit a2c739d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Wait with merge PRs that shouldn't be merged instantly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants