Skip to content

Fix PHPStan errors #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Fix PHPStan errors #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3730645
Fix errors found by PHPStan
adriendupuis Feb 12, 2025
4101eb2
Empty trigger
adriendupuis Feb 12, 2025
999fd8e
code_samples_usage.php: Tri more visible 'highlighted line' marker
adriendupuis Feb 12, 2025
9d0056f
code_samples_usage.php: Tri more visible 'highlighted line' marker
adriendupuis Feb 12, 2025
d6a67d5
code_samples_usage.php: Tri more visible 'highlighted line' marker
adriendupuis Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code_samples/search/custom/src/EventSubscriber/CustomQueryFilterSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd;
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\ObjectStateIdentifier;
use Ibexa\Contracts\ElasticSearch\Query\Event\QueryFilterEvent;
use Ibexa\Contracts\Elasticsearch\Query\Event\QueryFilterEvent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😄

use Symfony\Component\EventDispatcher\EventSubscriberInterface;

final class CustomQueryFilterSubscriber implements EventSubscriberInterface
Expand Down
2 changes: 2 additions & 0 deletions ...les/search/custom/src/Query/Aggregation/Elasticsearch/PriorityRangeAggregationVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ public function supports(Aggregation $aggregation, LanguageFilter $languageFilte

/**
* @param \App\Query\Aggregation\PriorityRangeAggregation $aggregation
*
* @return array<string, array<string, mixed>>
*/
public function visit(AggregationVisitor $dispatcher, Aggregation $aggregation, LanguageFilter $languageFilter): array
{
Expand Down
2 changes: 1 addition & 1 deletion code_samples/search/custom/src/Query/Criterion/Elasticsearch/CameraManufacturerVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function supports(Criterion $criterion, LanguageFilter $languageFilter):
}

/**
* @param \App\Query\Criterion\Elasticsearch\CameraManufacturerCriterion $criterion
* @param \App\Query\Criterion\CameraManufacturerCriterion $criterion
*/
public function visit(CriterionVisitor $dispatcher, Criterion $criterion, LanguageFilter $languageFilter): array
{
Expand Down
2 changes: 1 addition & 1 deletion code_samples/search/custom/src/Query/Criterion/Solr/CameraManufacturerVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function canVisit(Criterion $criterion)
}

/**
* @param \App\Query\Criterion\Solr\CameraManufacturerCriterion $criterion
* @param \App\Query\Criterion\CameraManufacturerCriterion $criterion
*/
public function visit(Criterion $criterion, CriterionVisitor $subVisitor = null)
{
Expand Down
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,11 +355,6 @@ parameters:
count: 1
path: code_samples/search/custom/src/Query/Aggregation/Elasticsearch/PriorityRangeAggregationResultExtractor.php

-
message: "#^Method App\\\\Query\\\\Aggregation\\\\Elasticsearch\\\\PriorityAggregationVisitor\\:\\:visit\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: code_samples/search/elasticsearch/src/Query/Aggregation/Elasticsearch/PriorityAggregationVisitor.php

-
message: "#^Method App\\\\Query\\\\Criterion\\\\Elasticsearch\\\\CameraManufacturerVisitor\\:\\:visit\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion tools/code_samples/code_samples_usage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function displayBlocks(array $docFileBlocks, string $docFilePath = null, $lineOf
try {
$blockContents = getBlockContents($block);
foreach ($blockContents['contents'] as $contentLineNumber => $contentLine) {
$prefixedBlockContentLines[] = str_pad($contentLineNumber, 3, 0, STR_PAD_LEFT) . (in_array($contentLineNumber, $blockContents['highlights']) ? '⫸' : '⫶') . $contentLine;
$prefixedBlockContentLines[] = str_pad($contentLineNumber, 3, 0, STR_PAD_LEFT) . (in_array($contentLineNumber, $blockContents['highlights']) ? '❇️' : '⫶') . $contentLine;
}
echo implode(PHP_EOL, $prefixedBlockContentLines) . PHP_EOL . PHP_EOL;
} catch (Exception $exception) {
Expand Down
Loading