Optional pill for namespaces in LTS Updates #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview of modified Markdown: no Markdown change to preview. |
mnocon
changed the title
adriendupuis
approved these changes
Feb 19, 2025
mnocon
added a commit
that referenced
this pull request
Feb 19, 2025
* Added optional packages as a dedicated type * Regenerated reference * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: 4.6, master
Possible to review by commits:
Things done:
AI namespace before AI namespace after
It also removes some unwanted pills, like:
It's part of Experience, but it not a direct dependency for this package (https://github.com/ibexa/experience/blob/master/composer.json#L27, https://github.com/ibexa/engage/blob/main/composer.json#L14)
\\suffix for checking the namespacesWe're using
starts withto get the package based on the namespace:{% if fqcn ~ "\\" starts with namespace %} {% set package = namespace_package_map[namespace] %} {% endif %}Without the ending slash a collision is possible: a namespace like
Ibexa\Conctracts\ConnectorAi\Actioncould match:Ibexa\Contracts\ConnectorAi- https://github.com/ibexa/connector-ai/blob/main/composer.json#L58Ibexa\Contracts\Connect- https://github.com/ibexa/connect/blob/main/composer.json#L61Making it possible to assign wrong package for the namespace - getting a wrong pill in the result.
Adding
\\at the end makes sure that we match the right package.Changes
Diff without whitespace changes (
git diff -w):