Applied Icons reference feedback #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julitafalcondusza
approved these changes
Feb 24, 2025
mnocon
added a commit
that referenced
this pull request
Feb 25, 2025
* Applied Icons reference feedback * Fixed links * Fixed links2 * Added description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: master, 4.6
Feedback after the demo:
Other Twig functionspage, as it's a container for various things. We now have a section dedicated for icons, which I think is justified because of its lenght - and the one taxonomy function is moved to the content section (which imho is ok, as it works with content)Checklist