Skip to content

IBX-4064: Enh search page nav #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Update importing_assets_from_bundle.md
merged 3 commits into from
Mar 13, 2025
Merged

IBX-4064: Enh search page nav #2659

merged 3 commits into from
Mar 13, 2025

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 6, 2025 •
edited
Loading

Question Answer
JIRA Ticket IBX-4064
Versions All
Edition All

(taken from ibexa/documentation-user#346)

  • Hide last page icon as meaning less (nothing interesting there, this is not even the last page in some case)
  • Prevent last clicked first/previous/next/last page button from being highlighted.

Before
image

After
image

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

Preview of modified Markdown: no Markdown change to preview.

@adriendupuis adriendupuis merged commit 24add14 into master Mar 13, 2025
7 checks passed
@adriendupuis adriendupuis deleted the IBX-4064-enh-search-page branch March 13, 2025 13:51
adriendupuis added a commit that referenced this pull request Mar 13, 2025
@adriendupuis
IBX-4064: Enh search page nav (#2659)
9968c52 
* instantsearch.css: hide "last page" link
* instantsearch.css: don't highlight last clicked prev/next button

(cherry picked from commit 24add14)
adriendupuis added a commit that referenced this pull request Mar 13, 2025
@adriendupuis
IBX-4064: Enh search page nav (#2659)
d4ad1d6 
* instantsearch.css: hide "last page" link
* instantsearch.css: don't highlight last clicked prev/next button

(cherry picked from commit 24add14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

@dabrt dabrt dabrt approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

Assignees

No one assigned

Labels

Ready for MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adriendupuis @mnocon @dabrt @julitafalcondusza