Skip to content

Conversation

@mnocon mnocon marked this pull request as ready for review March 19, 2025 13:17
Comment on lines 42 to 43
### Search
- The lists of [search criteria](search_criteria_reference.md) and [sort clauses](sort_clause_reference.md) have been expanded to show their support for [searching in Trash](search_in_trash_reference.md).

This comment was marked as resolved.

Copy link
Contributor

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments


### Page Builder clipboard

- Described how you can use the [Page Builder's clipboard]([[= user_doc =]]content_management/create_edit_pages/#copy-blocks) to copy blocks between landing pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Described how you can use the [Page Builder's clipboard]([[= user_doc =]]content_management/create_edit_pages/#copy-blocks) to copy blocks between landing pages.
- Described how you can use the [Page Builder's clipboard]([[= user_doc =]]content_management/create_edit_pages/#copy-blocks) to copy blocks between pages


### REST API

- Described endpoints for [Segment](../api/rest_api/rest_api_reference/rest_api_reference.html#segments) and [Segment Group](http://localhost:8103/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#segment-groups) management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Described endpoints for [Segment](../api/rest_api/rest_api_reference/rest_api_reference.html#segments) and [Segment Group](http://localhost:8103/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#segment-groups) management.
- Described endpoints for [Segment](../api/rest_api/rest_api_reference/rest_api_reference.html#segments) and [Segment Group](http://localhost:8103/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#segment-groups) management

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thans! I've also removed the localhost link 🙈


- Described endpoints for [Segment](../api/rest_api/rest_api_reference/rest_api_reference.html#segments) and [Segment Group](http://localhost:8103/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#segment-groups) management.
- Described endpoints for [AI Action Configurations](../api/rest_api/rest_api_reference/rest_api_reference.html#ai-actions-list-action-configurations) and [AI Action Types](../api/rest_api/rest_api_reference/rest_api_reference.html#ai-actions-list-action-types)
- Improved the example for [creating Orders](../api/rest_api/rest_api_reference/rest_api_reference.html#orders-create-order), showing how to pass shipping cost data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Improved the example for [creating Orders](../api/rest_api/rest_api_reference/rest_api_reference.html#orders-create-order), showing how to pass shipping cost data.
- Improved the example for [creating Orders](../api/rest_api/rest_api_reference/rest_api_reference.html#orders-create-order), to show how to pass shipping cost data


### HTTP Cache

- Improved the VCL snippet to cache the first ESI request when [using Basic Auth with Fastly](fastly.md#enable-basic-auth-on-fastly).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Improved the VCL snippet to cache the first ESI request when [using Basic Auth with Fastly](fastly.md#enable-basic-auth-on-fastly).
- Improved the VCL snippet to cache the first ESI request when [using Basic Auth with Fastly](fastly.md#enable-basic-auth-on-fastly)


### Security

- Expanded security recommendations to follow when working with [images submitted by users](images.md#configuring-image-variations).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Expanded security recommendations to follow when working with [images submitted by users](images.md#configuring-image-variations).
- Expanded security recommendations to follow when working with [images submitted by users](images.md#configuring-image-variations)

It's a bullet and we don't put fullstops at the end of bullets


### Templating

- The new [icon reference](icon_twig_functions.md#icons-reference) lists all the icons you can use when extending the back office.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The new [icon reference](icon_twig_functions.md#icons-reference) lists all the icons you can use when extending the back office.
- Added the [icon reference](icon_twig_functions.md#icons-reference) that lists all the icons you can use when extending the back office

### Templating

- The new [icon reference](icon_twig_functions.md#icons-reference) lists all the icons you can use when extending the back office.
- The following Twig functions now support objects implementing the [`ContentAwareInterface`](../api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Values-Content-ContentAwareInterface.html) as arguments:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The following Twig functions now support objects implementing the [`ContentAwareInterface`](../api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Values-Content-ContentAwareInterface.html) as arguments:
- Updated descriptions of the following Twig functions to mention their support for objects implementing the [`ContentAwareInterface`](../api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Values-Content-ContentAwareInterface.html) as arguments:


### DDEV

- Described how you can use the [Ibexa Cloud addons](ddev_and_ibexa_cloud.md#with-ibexa-cloud-add-ons) when working with [[= product_name_cloud =]] projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Described how you can use the [Ibexa Cloud addons](ddev_and_ibexa_cloud.md#with-ibexa-cloud-add-ons) when working with [[= product_name_cloud =]] projects.
- Described how you can use the [Ibexa Cloud addons](ddev_and_ibexa_cloud.md#with-ibexa-cloud-add-ons) when working with [[= product_name_cloud =]] projects


### [[= product_name_cloud =]]

- Described how to [set up Composer authentication](install_on_ibexa_cloud.md#composer-authentication-using-the-web-console) when creating an [[= product_name_cloud =]] project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Described how to [set up Composer authentication](install_on_ibexa_cloud.md#composer-authentication-using-the-web-console) when creating an [[= product_name_cloud =]] project.
- Described how to [set up Composer authentication](install_on_ibexa_cloud.md#composer-authentication-using-the-web-console) when creating an [[= product_name_cloud =]] project


#### PHP API

The PHP API has been enhanced with the following new classes and interfaces:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The PHP API has been enhanced with the following new classes and interfaces:
Enhanced the PHP API with the following new classes and interfaces:

Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use absolute https://doc.ibexa.co/en/latest/ links like the rest of the page.

I would remove final periods from list items (like already @dabrt suggested).


### REST API

- Described endpoints for [Segment](../api/rest_api/rest_api_reference/rest_api_reference.html#segments) and [Segment Group](http://localhost:8103/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#segment-groups) management.

This comment was marked as resolved.

@mnocon
Copy link
Contributor Author

mnocon commented Mar 25, 2025

@adriendupuis @dabrt than you for the suggestions, all of them are applied in 30631c4 - could you please look again?

@mnocon mnocon requested a review from dabrt March 25, 2025 09:13
@mnocon mnocon merged commit ec1a568 into master Mar 25, 2025
7 checks passed
@mnocon mnocon deleted the new-in-febuary branch March 25, 2025 14:11
mnocon added a commit that referenced this pull request Mar 25, 2025
* Added entry

* New in the doc: February

* Fixed link

* Removed plural

* Fixed cloud sentence

* Review fixes

* Review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants