Skip to content

IBX-9737: Enhance PHP API Ref generation tool #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Update importing_assets_from_bundle.md
merged 3 commits into from
Mar 21, 2025
Merged

IBX-9737: Enhance PHP API Ref generation tool #2677

merged 3 commits into from
Mar 21, 2025

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 21, 2025 •
edited
Loading

Question Answer
JIRA Ticket IBX-9737
Versions 4.6, master
Edition All
  • Ease the use of under development version.
  • Control new line in "Optional" pill tool tip so it's before the vendor/package name instead of in the middle.

Development version

Config example for 4.6.x-dev with incoming not-tagged-yet collaboration packages:

- DXP_VERSION='4.6.*';
- DXP_ADD_ONS=(connector-ai connector-openai automated-translation product-catalog-date-time-attribute);
+ DXP_VERSION='4.6.x-dev';
+ DXP_ADD_ONS=(connector-ai connector-openai automated-translation product-catalog-date-time-attribute collaboration share fieldtype-richtext-rte);
- BASE_DXP_BRANCH='';
- VIRTUAL_DXP_VERSION='';
+ BASE_DXP_BRANCH='4.6';
+ VIRTUAL_DXP_VERSION='4.6.19';

Tooltip new line

Before: New line after slash
New line after slash

After: New line before package
image

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions
Copy link

Preview of modified Markdown: no Markdown change to preview.

@adriendupuis adriendupuis marked this pull request as ready for review March 21, 2025 10:48
@adriendupuis adriendupuis changed the title Enh php api ref tool Enhance PHP API Ref generation tool Mar 21, 2025
@adriendupuis adriendupuis changed the title Enhance PHP API Ref generation tool IBX-9737: Enhance PHP API Ref generation tool Mar 21, 2025
mnocon
mnocon approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adriendupuis adriendupuis merged commit b0bba5a into master Mar 21, 2025
6 of 7 checks passed
@adriendupuis adriendupuis deleted the enh-php-api-ref-tool branch March 21, 2025 14:10
adriendupuis added a commit that referenced this pull request Mar 21, 2025
@adriendupuis
IBX-9737: Enhance PHP API Ref generation tool (#2677)
e8ef96e 
* edition-tag.html.twig: New line before package

In the tooltip, the new line was often after the slash (between vendor and package). Now, it's just before the package ref, before the vendor.

https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#the-title-attribute

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#multiline_titles

* phpdoc.sh: Ease the targeting of a dev branch

(cherry picked from commit b0bba5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adriendupuis @mnocon