Skip to content

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Apr 23, 2025

Question Answer
JIRA Ticket IBX-9903
Versions 5.0, 4.6
Edition All

I choose to merge with existing Markdown comment.
It displays only added elements.
I used the addition of Markdown change count and PHP API Ref HTML change to compare with the limit to avoid long comment.

Tests:

Have been est

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

github-actions bot commented Apr 23, 2025

Preview of modified files: no change to preview.

@adriendupuis adriendupuis marked this pull request as ready for review April 23, 2025 18:47
@adriendupuis adriendupuis requested a review from mnocon April 24, 2025 00:18
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is wonderful 🤩

@adriendupuis adriendupuis merged commit dc56e45 into master Apr 24, 2025
7 checks passed
@adriendupuis adriendupuis deleted the preview_comment_php_api_ref branch April 24, 2025 08:31
adriendupuis added a commit that referenced this pull request Apr 24, 2025
* Add PHP API Reference's new entries to preview comment

(cherry picked from commit dc56e45)
@adriendupuis adriendupuis changed the title Add PHP API Ref to preview comment IBX-9903: Add PHP API Ref to preview comment Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants