-
Notifications
You must be signed in to change notification settings - Fork 82
Twig Components #2739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twig Components #2739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I have a doubt about the YAML code samples, they seem to use the old component group identifiers.
I would try to cross-link a bit more,
and to explain the examples a bit more.
We will have to document how to move now to the new components between 4.6.19 and .20, without waiting for 5.0 to do it.
docs/administration/back_office/back_office_elements/custom_components.md
Outdated
Show resolved
Hide resolved
docs/administration/back_office/back_office_elements/custom_components.md
Outdated
Show resolved
Hide resolved
docs/administration/back_office/back_office_elements/custom_components.md
Show resolved
Hide resolved
code_samples/back_office/dashboard/article_tab/config/custom_services.yaml
Outdated
Show resolved
Hide resolved
$template: '@@ibexadesign/account/login/oauth2_login.html.twig' | ||
tags: | ||
- { name: ibexa.admin_ui.component, group: login-form-after } | ||
- { name: ibexa.twig.component, group: login-form-after } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it to use up-to-date values - but the BC layer is here: https://github.com/ibexa/admin-ui/blob/bb2de218e1f6ba8d2d5d4e9ebeabfc6b21e5a956/src/lib/Component/Registry.php
docs/administration/back_office/back_office_tabs/back_office_tabs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrien Dupuis <[email protected]>
@adriendupuis I've applied your feedback in: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (Approvable w/ the application og the language declaration fix for colorization)
|
||
### Examples | ||
|
||
``` hmml+twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` hmml+twig | |
``` html+twig |
|
||
### Examples | ||
|
||
``` hmml+twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` hmml+twig | |
``` html+twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Fixed in 212fdda
…2741) * Marked Dashboard as Experience feature and mentioned Twig Components * Update docs/administration/dashboard/customize_dashboard.md Co-authored-by: Adrien Dupuis <[email protected]> --------- Co-authored-by: Adrien Dupuis <[email protected]>
code_samples/ change report
|
* Twig Components * Rebuild * Added `admin-ui` prefix * Review suggestions * Make Symfony Profiler more visible * Updated screenshot * Applied suggestions from code review Co-authored-by: Adrien Dupuis <[email protected]> * Manual fixes * Fixed broken link * Fixed syntac typo * Marked Dashboard as Experience feature and mentioned Twig Components (#2741) * Marked Dashboard as Experience feature and mentioned Twig Components * Update docs/administration/dashboard/customize_dashboard.md Co-authored-by: Adrien Dupuis <[email protected]> --------- Co-authored-by: Adrien Dupuis <[email protected]> * Removed mentions of Storefront Twig Component groups --------- Co-authored-by: Adrien Dupuis <[email protected]>
Previews:
The Twig Components Package will be part of the OSS edition: once that's available I will add links to the classes from the PHP API Reference
Checklist