[v5] Adjust code samples

[mnocon]

Target: 5.0 only!

See the failing build on v5:
https://github.com/ibexa/documentation-developer/actions/runs/15046924482/job/42291716387?pr=2739

There are two types of errors:

Commands

   Line   recent_activity/src/Command/MonitorRecentContentCreationCommand.php   
 ------ ---------------------------------------------------------------------- 
  19     Property                                                              
         App\Command\MonitorRecentContentCreationCommand::$defaultName has no  
         type specified.                                                       
         🪪 missingType.property                                               
  21     Property                                                              
         App\Command\MonitorRecentContentCreationCommand::$defaultDescription  
         has no type specified.                                                
         🪪 missingType.property   

I've switched to registering the Commands using the AsCommand attribute: https://symfony.com/doc/current/console.html#registering-the-command

Normalizers and denormalizers

   Line   field_types/2dpoint_ft/src/Serializer/Point2D/ValueNormalizer.php                      
 ------ --------------------------------------------------------------------------------------- 
  9      Non-abstract class App\Serializer\Point2D\ValueNormalizer contains                     
         abstract method getSupportedTypes() from interface                                     
         Symfony\Component\Serializer\Normalizer\NormalizerInterface.                           
  11     Return type mixed of method                                                            
         App\Serializer\Point2D\ValueNormalizer::normalize() is not covariant                   
         with return type array|ArrayObject|bool|float|int|string|null of                       
         method                                                                                 
         Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize().              
  19     Method                                                                                 
         App\Serializer\Point2D\ValueNormalizer::supportsNormalization()                        
         overrides method                                                                       
         Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization()   
         but misses parameter #3 $context.                                                      
  19     Return type mixed of method                                                            
         App\Serializer\Point2D\ValueNormalizer::supportsNormalization() is                     
         not covariant with return type bool of method                                          
         Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization().  

The interfaces have changed, see:

• https://symfony.com/blog/new-in-symfony-6-3-performance-improvements#improved-performance-of-serializer-normalizers-denormalizers
• [Serializer] Add methods getSupportedTypes to allow better performance symfony/symfony-docs#18042
• https://symfony.com/doc/current/serializer/custom_normalizer.html#creating-a-new-normalizer

[github-actions]

Preview of modified files

Preview of modified Markdown:

• docs/administration/dashboard/php_api_dashboard_service.md
• docs/administration/recent_activity/recent_activity.md
• docs/ai_actions/extend_ai_actions.md
• docs/api/php_api/php_api.md
• docs/commerce/order_management/order_management_api.md
• docs/commerce/payment/extend_payment.md
• docs/commerce/payment/payment_api.md
• docs/commerce/payment/payment_method_api.md
• docs/commerce/shipping_management/shipment_api.md
• docs/commerce/shipping_management/shipping_method_api.md
• docs/content_management/content_api/browsing_content.md
• docs/content_management/content_api/creating_content.md
• docs/content_management/content_api/managing_content.md
• docs/content_management/content_management_api/bookmark_api.md
• docs/content_management/data_migration/data_migration_api.md
• docs/content_management/workflow/workflow_api.md
• docs/multisite/languages/language_api.md
• docs/pim/catalog_api.md
• docs/pim/price_api.md
• docs/pim/product_api.md
• docs/search/search_api.md
• docs/templating/render_content/render_content_in_php.md

[adriendupuis]

$context seems not used between this set and its override at line 97 (below // Create a new payment)

[mnocon]

You're right, it doesn't make a lot of sense in the context of the Command - I've included it to improve the doc a bit:

Please compare:
https://ez-systems-developer-documentation--2748.com.readthedocs.build/en/2748/commerce/payment/extend_payment/#attach-custom-data-to-payments
and
https://doc.ibexa.co/en/latest/commerce/payment/extend_payment/#attach-custom-data-to-payments

I could add the getContext line somewhere else and then "glue" 2 includes together, I just prefered having it in one include as I think it's easier to maintain

[adriendupuis]

That's tricky!
I didn't see that extend_payment.md uses it in reverse order…
Maybe a comment in the cut-out line to explain why it's there?

Suggested change

	$context = $payment->getContext();
	$context = $payment->getContext();
	// Will be overridden later but used to illustrate `getContext()`

[mnocon]

Added in 79c5c1a - I'll wait for the "check code samples" job to make sure I did it right

[github-actions]

code_samples/ change report

Report's diff is too long to be displayed in a comment.

Download colorized diff