Skip to content

[5.0] Added missing return type #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

[5.0] Added missing return type #2766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code_samples/back_office/limitation/src/Security/Limitation/CustomLimitationType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function getCriterion(Limitation $value, UserReference $currentUser): Cri
throw new NotImplementedException(__METHOD__);
}

public function valueSchema()
public function valueSchema(): never
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel never is the right keyword to use here: https://www.php.net/manual/en/language.types.never.php

I would stick to interface here but I guess never will also work in this particular example.

{
throw new NotImplementedException(__METHOD__);
}
Expand Down
Loading