-
Notifications
You must be signed in to change notification settings - Fork 82
[Discounts] Configuration #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de5af4e
to
f2104e8
Compare
Preview of modified filesPreview of modified Markdown: |
b3ca350
to
03e08d8
Compare
konradoboza
approved these changes
Jun 11, 2025
03e08d8
to
eb9047b
Compare
eb9047b
to
09fed3a
Compare
adriendupuis
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor grammar and var usage (I'm pretty sure [[[= var =]]](url)
case was previously studied before as working) to fix but approvable as a whole
Co-authored-by: Adrien Dupuis <[email protected]>
adriendupuis
approved these changes
Jun 16, 2025
# Conflicts: # docs/discounts/discounts.md # mkdocs.yml
adriendupuis
added a commit
that referenced
this pull request
Jun 16, 2025
* [Discounts] Described Discounts API (#2783) * [Discounts] Configuration (#2781) --------- Co-authored-by: Adrien Dupuis <[email protected]>
adriendupuis
added a commit
that referenced
this pull request
Jun 16, 2025
* [Discounts] Described Discounts API (#2783) * [Discounts] Configuration (#2781) --------- Co-authored-by: Adrien Dupuis <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the Discounts configuration, describing options from:
and the previously described pagination options.