Skip to content

Documented Twig Component attribute #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 15, 2025
Merged

Documented Twig Component attribute #2793

merged 8 commits into from
Jul 15, 2025

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jun 17, 2025 •
edited
Loading

@mnocon mnocon force-pushed the twig-component-attributes branch from d4fa21c to 8e56520 Compare June 17, 2025 08:08
@github-actions GitHub Actions
Copy link

Preview of modified files

Preview of modified Markdown:

adriendupuis
adriendupuis reviewed Jun 18, 2025
View reviewed changes
@mnocon mnocon requested review from adriendupuis and wiewiurdp July 3, 2025 11:55
mnocon
mnocon commented Jul 10, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/back_office/components/MyComponent.php


code_samples/back_office/components/MyComponent.php

docs/templating/components.md@26:    ``` php hl_lines="8-11"
docs/templating/components.md@27:    [[= include_file('code_samples/back_office/components/MyComponent.php', glue='    ') =]]
docs/templating/components.md@28:    ```

The following line doesn't include file correctly:     [[= include_file('code_samples/back_office/components/MyComponent.php', glue='    ') =]]


Download colorized diff

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
            


  

  
  

  
      @mnocon
  mnocon


          requested a review
  from a team


    July 15, 2025 09:30    
    




  

  
  

  
      @ezrobot
  ezrobot


          requested review from
    dabrt and 
    julitafalcondusza

  and removed request for
    a team


    July 15, 2025 09:30    
    




  

  

    
  


  

      


    @mnocon
mnocon



    mentioned this pull request
    
      Jul 15, 2025
    





  


  

      
     Merged

  





  
  

      
        
      
      


  
    
    
  


    4 tasks
  





  









      

  
        

  

      

  dabrt
  

  
          

            
                  dabrt
  

            

            approved these changes


            
                
                  Jul 15, 2025
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @mnocon
      
        @dabrt
  




      

        
          Apply suggestion from @dabrt
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          4ae698b
        
      

    

  

    

      
Co-authored-by: Tomasz Dąbrowski <[email protected]>

    







  








      

  
          
 
  

    
  

  


        
        @mnocon
  mnocon



        merged commit 7930e97
      into

      
  
    5.0
  


    Jul 15, 2025

      

        3 of 6 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @mnocon
  mnocon


    
    deleted the
    
      
        twig-component-attributes
    
    branch

    July 15, 2025 14:07    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
    



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @wiewiurdp
  
    wiewiurdp



    
      
        
      
    
    wiewiurdp approved these changes

  


        

    


  
      @dabrt
  
    dabrt



    
      
        
      
    
    dabrt approved these changes

  


      

          


  
      @adriendupuis
  
    adriendupuis


                Awaiting requested review from adriendupuis


        
      

      

          


  
      @julitafalcondusza
  
    julitafalcondusza


                Awaiting requested review from julitafalcondusza


        
      


      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    Needs DOC review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @mnocon 
        
          @wiewiurdp 
        
          @adriendupuis 
        
          @dabrt