Skip to content

[Misc] Various small fixes #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2025
Merged

[Misc] Various small fixes #2809

merged 4 commits into from
Jul 3, 2025

Conversation

@mnocon
Copy link
Contributor

@mnocon mnocon commented Jul 2, 2025 •
edited
Loading

Target: 4.6, 5.0

A small batch of fixes I found when browsing the doc.

mnocon
mnocon commented Jul 2, 2025
View reviewed changes
docs/api/php_api/php_api.md

This isn't required in template functions or controller code, as the HTTP layer takes care of identifying the user, and automatically sets it in the repository.

If you want to identify a user with their credentials instead, provide them in the following way:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API has been removed in 3.3

@mnocon mnocon marked this pull request as ready for review July 2, 2025 14:17
@mnocon mnocon requested a review from a team July 2, 2025 14:17
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 2, 2025 14:18
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Preview of modified files

Preview of modified Markdown:

adriendupuis
adriendupuis reviewed Jul 2, 2025
View reviewed changes
docs/tutorials/beginner_tutorial/img/bike_tutorial_homepage_install_clean.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be 4.6.21? (You can event edit the code w/ browser console if you don't want to update your current install :p)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to cheat a bit more: 3b795c8

I see no value in having the exact version there, as long it says 4.6 (and it means less maintanence for us)

@mnocon mnocon requested a review from adriendupuis July 2, 2025 15:14
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/api/public_php_api/src/EventSubscriber/MyEventSubcriber.php


code_samples/api/public_php_api/src/EventSubscriber/MyEventSubcriber.php

docs/api/event_reference/event_reference.md@15:``` php
docs/api/event_reference/event_reference.md@16:[[= include_file('code_samples/api/public_php_api/src/EventSubscriber/MyEventSubcriber.php') =]]
docs/api/event_reference/event_reference.md@17:```

001⫶<?php declare(strict_types=1);
002⫶
003⫶namespace App\EventSubscriber;
004⫶
005⫶use Ibexa\Contracts\Core\Repository\Events\Content\CopyContentEvent;
006⫶use Symfony\Component\EventDispatcher\EventSubscriberInterface;
007⫶
008⫶class MyEventSubcriber implements EventSubscriberInterface
009⫶{
010⫶    public static function getSubscribedEvents()
011⫶    {
012⫶        return [
013⫶            CopyContentEvent::class => ['onCopyContent', 0],
014⫶        ];
015⫶    }
016⫶
017⫶    public function onCopyContent(CopyContentEvent $event): void
018⫶    {
019⫶        // your implementation
020⫶    }
021⫶}


Download colorized diff

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
        





      

  
          
 
  

    
  

  


        
        @mnocon
  mnocon



        merged commit 3292fd2
      into

      
  
    4.6
  


    Jul 3, 2025

      

        7 of 8 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @mnocon
  mnocon


    
    deleted the
    
      
        small-fixes
    
    branch

    July 3, 2025 09:16    
    




  



  
    
  
  

    

  mnocon 

      added a commit
      that referenced
      this pull request

    
      Jul 3, 2025
    
    

      


  

    

      


  

      
        @mnocon
  





      

        
          [Misc] Various small fixes (#2809)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          22955b1
        
      

    

  

    

      
* [Misc] Various small fixes

* PHP & JS CS Fixes

* Adjusted screenshot

    




    

  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
    



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @adriendupuis
  
    adriendupuis



    
      
        
      
    
    adriendupuis approved these changes

  


        

    


  
      @julitafalcondusza
  
    julitafalcondusza



    
      
        
      
    
    julitafalcondusza approved these changes

  


      

          


  
      @dabrt
  
    dabrt


                Awaiting requested review from dabrt


        
      


      






    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    Needs DOC review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @mnocon 
        
          @adriendupuis 
        
          @julitafalcondusza