Skip to content

Conversation

vidarl
Copy link
Contributor

@vidarl vidarl commented Jul 4, 2025

Question Answer
JIRA Ticket N/A
Versions 4.6
Edition Content/Headless, Experience, Commerce

The current instructions are incomplete, ref https://symfony.com/bundles/LexikJWTAuthenticationBundle/current/index.html#generate-the-ssl-keys

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

github-actions bot commented Jul 4, 2025

Preview of modified files

Preview of modified Markdown:

@vidarl vidarl changed the title Added instructions on how to generate PEM generate keypair, needed by JWT authentication Added instructions on how to generate PEM keypair, needed by JWT authentication Jul 7, 2025
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please disregard, the review was sent too quickly)

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions, thank you Vidar for creating this PR!

@vidarl
Copy link
Contributor Author

vidarl commented Jul 31, 2025

@mnocon : FYI, I am back from vacation and have finally approved your suggestions

@vidarl vidarl requested a review from mnocon July 31, 2025 10:05
@mnocon mnocon requested a review from a team July 31, 2025 11:12
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 31, 2025 11:12
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vidar!

@mnocon mnocon merged commit 9dbd69b into 4.6 Aug 5, 2025
12 checks passed
@mnocon mnocon deleted the jwt_generate_keypair branch August 5, 2025 11:27
mnocon added a commit that referenced this pull request Aug 5, 2025
…entication (#2812)

* Added instructions on how to generate key pair for JWT authentication

* Apply suggestions from code review

Co-authored-by: Marek Nocoń <[email protected]>

---------

Co-authored-by: Marek Nocoń <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants