-
Notifications
You must be signed in to change notification settings - Fork 82
IBX-10311: Changed example of field mapper #2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview of modified filesPreview of modified Markdown: |
adamwojs
reviewed
Jul 15, 2025
code_samples/search/custom/src/Search/FieldMapper/WebinarEventParentNameFieldMapper.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
Jul 31, 2025
konradoboza
approved these changes
Jul 31, 2025
mnocon
requested changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see that the build is failing with:
WARNING - [macros] - ERROR # _Macro Rendering Error_
_File_: `search/extensibility/solr_document_field_mappers.md`
_FileNotFoundError_: [Errno 2] No such file or directory: '/home/runner/work/documentation-developer/documentation-developer/code_samples/search/custom/src/Search/FieldMapper/WebinarEventTitleFulltextFieldMapper.php'
code_samples/ change report
|
mnocon
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
mnocon
pushed a commit
that referenced
this pull request
Aug 6, 2025
* IBX-10311: Changed example of field mapper * PHP & JS CS Fixes * Corrected FQCN * Corrected filename --------- Co-authored-by: Mateusz Dębiński <[email protected]> Co-authored-by: mateuszdebinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing this example, we came to an agreement that it should be changed as we do not support fulltext in this place. Instead, fulltext should be added via \Ibexa\Core\FieldType\MapLocation\SearchField::getIndexData
Checklist