Skip to content

Conversation

Copy link

github-actions bot commented Aug 5, 2025

@mnocon mnocon marked this pull request as ready for review August 5, 2025 18:58
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small remarks

Co-authored-by: julitafalcondusza <[email protected]>
Copy link

@barw4 barw4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Taxonomy part. I would also mention there is a possibility ot assign Taxonomy Limitation to ibexa/assign as it wasn't the case before.


#### Breaking changes

- The `Ibexa\FieldTypeRichText\RichText\Validator\CustomTagsValidator` class has been renamed to `Ibexa\FieldTypeRichText\RichText\Validator\CustomTemplateValidator`, expanding its responsibility to validate both [custom tags](extend_online_editor.md# configure-custom-tags) and [custom styles](extend_online_editor.md#configure-custom-styles)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but should there be a space in the link, between anchor and anchor-id?

Suggested change
- The `Ibexa\FieldTypeRichText\RichText\Validator\CustomTagsValidator` class has been renamed to `Ibexa\FieldTypeRichText\RichText\Validator\CustomTemplateValidator`, expanding its responsibility to validate both [custom tags](extend_online_editor.md# configure-custom-tags) and [custom styles](extend_online_editor.md#configure-custom-styles)
- The `Ibexa\FieldTypeRichText\RichText\Validator\CustomTagsValidator` class has been renamed to `Ibexa\FieldTypeRichText\RichText\Validator\CustomTemplateValidator`, expanding its responsibility to validate both [custom tags](extend_online_editor.md#configure-custom-tags) and [custom styles](extend_online_editor.md#configure-custom-styles)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obraz

Fixed in 97ea04c , thanks!


This allows you to query for only a subset of relations, as in the following example:

``` json

This comment was marked as resolved.

Copy link
Contributor Author

@mnocon mnocon Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, there is a graphql variant as well (https://pygments.org/languages/) - will be fixed in a follow-up commit 🙇

Edit: done in 97ea04c

@mnocon
Copy link
Contributor Author

mnocon commented Aug 6, 2025

+1 for Taxonomy part. I would also mention there is a possibility ot assign Taxonomy Limitation to ibexa/assign as it wasn't the case before.

Added in 97ea04c to the release notes:

In addition, you can now use the [Taxonomy limitation](limitation_reference.md#taxonomy-limitation) together with the `taxonomy/assign` policy.

@mnocon mnocon merged commit 712b4e1 into release-4.6.22 Aug 6, 2025
6 of 7 checks passed
@mnocon mnocon deleted the release-notes branch August 6, 2025 11:02
@mnocon mnocon mentioned this pull request Aug 6, 2025
mnocon added a commit that referenced this pull request Aug 6, 2025
* IBX-10262: Added mention of the renamed class

* Release notes for 4.6.22

* Apply suggestions from code review

Co-authored-by: julitafalcondusza <[email protected]>

* Review fixes

* Fixed link

* Last minute fixes

---------

Co-authored-by: julitafalcondusza <[email protected]>
mnocon added a commit that referenced this pull request Aug 6, 2025
* Added new Twig Component group (#2790)

* Twig Component follow ups (#2792)

* Added Priority for YAML configuration

* Added doc for storefront groups

* Adjusted paths

* Update docs/templating/layout/customize_storefront_layout.md

Co-authored-by: julitafalcondusza <[email protected]>

---------

Co-authored-by: julitafalcondusza <[email protected]>

* [Twig Components] Added Menu component (#2799)

* Docs: Add Menu component to Twig Components documentation

* Docs: Extend Twig Components YAML example with Menu component

* Discounts 4.6.22 (#2810)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

---------

Co-authored-by: Konrad Oboza <[email protected]>

* IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 (#2525)

* Symbol attribute type described

* Fixes after review

* PHP CS Fixes

* Resolved conflicts in product search criteria

* Added composer dependency

* fixes

* review fixes

* PHP & JS CS Fixes

* symbol_attribute_type.md moved to Attributes folder

* fixes; mysql added

* fix in the table

* fix

---------

Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Marek Nocoń <[email protected]>

* Update 4.6.22 (#2851)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

* Added doc for IBX-9933

* Fixed badge

---------

Co-authored-by: Konrad Oboza <[email protected]>

* IBX-9845: Solr9 (#2866)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

* Described requirements

* Added Solr 9 instructions

* Fixed link

* Updated instructions

* Apply suggestions from code review

Co-authored-by: julitafalcondusza <[email protected]>

---------

Co-authored-by: Konrad Oboza <[email protected]>
Co-authored-by: julitafalcondusza <[email protected]>

* Release notes (#2869)

* IBX-10262: Added mention of the renamed class

* Release notes for 4.6.22

* Apply suggestions from code review

Co-authored-by: julitafalcondusza <[email protected]>

* Review fixes

* Fixed link

* Last minute fixes

---------

Co-authored-by: julitafalcondusza <[email protected]>

* Regenerated baseline

* Removed bullet

* Bumped latest tag

* Added PHP API links

* Added mention about Symbol attribute

* Fixed link

* Moved PHP API Symbol links

* symbol_attribute_type.md: Link to PHP API Ref

---------

Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>
Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Adrien Dupuis <[email protected]>
mnocon added a commit that referenced this pull request Aug 6, 2025
* Added new Twig Component group (#2790)

* Twig Component follow ups (#2792)

* Added Priority for YAML configuration

* Added doc for storefront groups

* Adjusted paths

* Update docs/templating/layout/customize_storefront_layout.md

Co-authored-by: julitafalcondusza <[email protected]>

---------

Co-authored-by: julitafalcondusza <[email protected]>

* [Twig Components] Added Menu component (#2799)

* Docs: Add Menu component to Twig Components documentation

* Docs: Extend Twig Components YAML example with Menu component

* Discounts 4.6.22 (#2810)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

---------

Co-authored-by: Konrad Oboza <[email protected]>

* IBX-9147: Symbol attribute type described in Developer Documentation - v4.6 (#2525)

* Symbol attribute type described

* Fixes after review

* PHP CS Fixes

* Resolved conflicts in product search criteria

* Added composer dependency

* fixes

* review fixes

* PHP & JS CS Fixes

* symbol_attribute_type.md moved to Attributes folder

* fixes; mysql added

* fix in the table

* fix

---------

Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Marek Nocoń <[email protected]>

* Update 4.6.22 (#2851)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

* Added doc for IBX-9933

* Fixed badge

---------

Co-authored-by: Konrad Oboza <[email protected]>

* IBX-9845: Solr9 (#2866)

* Adjusted code samples

* [Discounts] Added doc for 4.6.22

* Fixed limit mention

* Added update mention

* Removed mentions of OverridePrioritatization

* Wording

* Update code_samples/discounts/src/Command/ManageDiscountsCommand.php

Co-authored-by: Konrad Oboza <[email protected]>

* Fixed highlights

* Review suggestions

* Added missing v prefix

* Described requirements

* Added Solr 9 instructions

* Fixed link

* Updated instructions

* Apply suggestions from code review

Co-authored-by: julitafalcondusza <[email protected]>

---------

Co-authored-by: Konrad Oboza <[email protected]>
Co-authored-by: julitafalcondusza <[email protected]>

* Release notes (#2869)

* IBX-10262: Added mention of the renamed class

* Release notes for 4.6.22

* Apply suggestions from code review

Co-authored-by: julitafalcondusza <[email protected]>

* Review fixes

* Fixed link

* Last minute fixes

---------

Co-authored-by: julitafalcondusza <[email protected]>

* Regenerated baseline

* Removed bullet

* Bumped latest tag

* Added PHP API links

* Added mention about Symbol attribute

* Fixed link

* Moved PHP API Symbol links

* symbol_attribute_type.md: Link to PHP API Ref

---------

Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>
Co-authored-by: julitafalcondusza <[email protected]>
Co-authored-by: Adrien Dupuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants