Skip to content

Fix ibexa_content::viewAction #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025
Merged

Fix ibexa_content::viewAction #2873

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a113c3
Use ibexa_content::viewAction w/ two colons
adriendupuis Aug 11, 2025
908da2d
Use ibexa_content::viewAction w/ two colons
adriendupuis Aug 11, 2025
5edac6d
Use ibexa_content::viewAction w/ two colons
adriendupuis Aug 11, 2025
357c11c
request_lifecycle.md: Match on single colon
adriendupuis Aug 11, 2025
ddcc664
Update docs/release_notes/ibexa_dxp_v5.0_deprecations.md
adriendupuis Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code_samples/front/render_content_in_php/src/Command/ViewCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$viewParameters = [
'viewType' => $input->getOption('view-type'),
'_controller' => 'ibexa_content:viewAction',
'_controller' => 'ibexa_content::viewAction',
];

if (!empty($locationId)) {
Expand Down
4 changes: 2 additions & 2 deletions code_samples/tutorials/page_tutorial/templates/blocks/form/newsletter.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div class="row">
<div class="block-form {{ block_class }}">
{{ ibexa_http_cache_tag_relation_location_ids(locationId) }}
{{ render(controller('ibexa_content:viewAction', {
{{ render(controller('ibexa_content::viewAction', {
'contentId': contentId,
'locationId': locationId,
'viewType': 'embed'
})) }}
<style type="text/css">{{ block_style|raw }}</style>
</div>
</div>
</div>
46 changes: 23 additions & 23 deletions docs/infrastructure_and_maintenance/request_lifecycle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@

`UrlAliasRouter` (`Ibexa\Bundle\Core\Routing\UrlAliasRouter`):
This router uses the `UrlAliasService` to associate the `semanticPathinfo` to a location.
If it finds a location, the request receives the attributes **`locationId`** and **`contentId`**, **`viewType`** is set to `full`, and the **`_controller`** is set to `ibexa_content:viewAction` for now.
If it finds a location, the request receives the attributes **`locationId`** and **`contentId`**, **`viewType`** is set to `full`, and the **`_controller`** is set to `ibexa_content::viewAction` for now.

The `locale_listener` (priority 16) sets the request's **`_locale`** attribute.

Expand Down Expand Up @@ -160,7 +160,7 @@
As a reminder, the controller and its argument can be:

- A controller set by the matched route and the request as its argument.
- The default `ibexa_content:viewAction` controller and a `ContentView` as its argument.
- The default `ibexa_content::viewAction` controller and a `ContentView` as its argument.

Check failure on line 163 in docs/infrastructure_and_maintenance/request_lifecycle.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/infrastructure_and_maintenance/request_lifecycle.md#L163 

[Ibexa.Lists] Do not put fullstops at the end of bullets
Raw output 
{"message": "[Ibexa.Lists] Do not put fullstops at the end of bullets", "location": {"path": "docs/infrastructure_and_maintenance/request_lifecycle.md", "range": {"start": {"line": 163, "column": 89}}}, "severity": "ERROR"}
- A [custom controller](controllers.md) set by the matched view rule and a `View` or the request as its argument (most likely a `ContentView` but there is no restriction).

!!! caution "Permission control"
Expand Down Expand Up @@ -209,27 +209,27 @@

### Examples request attributes timeline

| Event | Service | Request attribute | Example |
|-----------------------------------|--------------------------------------------------------|--------------------------|-------------------------------------------|
| | http_kernel | pathInfo | /en/about |
| kernel.request | ibexa.siteaccess_match_listener | siteaccess | en |
| Ibexa\Core\MVC\Symfony\SiteAccess | Ibexa\Bundle\Core\EventListener\SiteAccessListener | semanticPathinfo | /about |
| kernel.request | router.default | _route | N/A |
| kernel.request | router.default | _controller | N/A |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | _route | ibexa.url.alias |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | _controller | <strong>ibexa_content:</strong>viewAction |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | viewType | full |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | contentId | 1 |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | locationId | 42 |
| kernel.request | locale_listener | _locale | en_GB |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Builder\ContentViewBuilder | view.content | Content |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Builder\ContentViewBuilder | view.location | Location |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Configurator\ViewProvider | view.templateIdentifier | @IbexaCore/default/content/full.html.twig |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Configurator\ViewProvider | view.controllerReference | null |
| kernel.controller | Ibexa\Bundle\Core\EventListener\ViewControllerListener | view | ContentView |
| kernel.controller | Ibexa\Bundle\Core\EventListener\ViewControllerListener | _controller | ibexa_content:viewAction |
| (controller execution) | http_kernel | | ContentView |
| kernel.view | Ibexa\Bundle\Core\EventListener\ViewRendererListener | response | Response |
| Event | Service | Request attribute | Example |
|-----------------------------------|--------------------------------------------------------|--------------------------|--------------------------------------------|
| | http_kernel | pathInfo | /en/about |
| kernel.request | ibexa.siteaccess_match_listener | siteaccess | en |

Check failure on line 215 in docs/infrastructure_and_maintenance/request_lifecycle.md

View workflow job for this annotation

GitHub Actions / vale

[vale] docs/infrastructure_and_maintenance/request_lifecycle.md#L215 

[Ibexa.DomainTermCapitalization] Use 'SiteAccess' instead of 'siteaccess'
Raw output 
{"message": "[Ibexa.DomainTermCapitalization] Use 'SiteAccess' instead of 'siteaccess'", "location": {"path": "docs/infrastructure_and_maintenance/request_lifecycle.md", "range": {"start": {"line": 215, "column": 96}}}, "severity": "ERROR"}
| Ibexa\Core\MVC\Symfony\SiteAccess | Ibexa\Bundle\Core\EventListener\SiteAccessListener | semanticPathinfo | /about |
| kernel.request | router.default | _route | N/A |
| kernel.request | router.default | _controller | N/A |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | _route | ibexa.url.alias |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | _controller | <strong>ibexa_content::</strong>viewAction |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | viewType | full |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | contentId | 1 |
| kernel.request | Ibexa\Bundle\Core\Routing\UrlAliasRouter | locationId | 42 |
| kernel.request | locale_listener | _locale | en_GB |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Builder\ContentViewBuilder | view.content | Content |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Builder\ContentViewBuilder | view.location | Location |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Configurator\ViewProvider | view.templateIdentifier | @IbexaCore/default/content/full.html.twig |
| kernel.controller | Ibexa\Core\MVC\Symfony\View\Configurator\ViewProvider | view.controllerReference | null |
| kernel.controller | Ibexa\Bundle\Core\EventListener\ViewControllerListener | view | ContentView |
| kernel.controller | Ibexa\Bundle\Core\EventListener\ViewControllerListener | _controller | ibexa_content::viewAction |
| (controller execution) | http_kernel | | ContentView |
| kernel.view | Ibexa\Bundle\Core\EventListener\ViewRendererListener | response | Response |


## End of HTTP response
Expand Down
2 changes: 1 addition & 1 deletion docs/release_notes/ibexa_dxp_v5.0_deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ Support for facet search has been dropped, use the `Aggregation` API instead.
!!! note "Dropped single colon notation"

[[= product_name_base =]]-named controllers can no longer be referenced using a single-colon notation.
For example, `ibexa_content:viewAction` must be changed to `ibexa_content::viewAction`.
For example, `ibexa_content::viewAction` must be changed to `ibexa_content::viewAction`.

The change affects the following controllers:

Expand Down
Loading