IBX-8674: Improve product completeness and attribute definitions #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mnocon
requested changes
Mar 20, 2025
Contributor
mnocon
left a comment
mnocon
left a comment
There was a problem hiding this comment.
One thing about attribute translations - and one suggestions about field types.
I really like the completeness note!
|
Preview of modified Markdown: |
Contributor
adriendupuis
left a comment
adriendupuis
left a comment
There was a problem hiding this comment.
Content is perfect. Just some format thingies.
Co-authored-by: Adrien Dupuis <[email protected]>
|
adriendupuis
approved these changes
Apr 15, 2025
dabrt
added a commit
that referenced
this pull request
Apr 15, 2025
* Improve product completeness and attribute definitions --------- Co-authored-by: Adrien Dupuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve product completeness and attribute definitions to include their intended use and impact.
Preview:
Product types
Work with product attributes
Product completeness
Create product types
Checklist