Skip to content

IBX-11480: Corrected cast to boolean in setBooleanValue #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateuszdebinski wants to merge 2 commits into
base: 4.6
Choose a base branch
from
+92 −13
Open

IBX-11480: Corrected cast to boolean in setBooleanValue #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c880658
IBX-11480: Corrected cast to boolean in setBooleanValue
Mar 17, 2026
0f1e13f
Corrected PHPStan
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ignore-gte-php8.0-errors.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
parameters:
ignoreErrors:
-
message: "#^Parameter \\#1 \\$string of function substr expects string, string\\|null given\\.$#"
count: 2
path: src/lib/RichText/Converter/Render/Embed.php

-
message: "#^Parameter \\#1 \\$string of function trim expects string, string\\|false given\\.$#"
count: 1
path: src/lib/RichText/Converter/Render/Template.php

-
message: '#^Parameter \#2 \$child of method DOMNode\:\:replaceChild\(\) expects DOMNode, DOMNameSpaceNode\|DOMNode given\.$#'
identifier: argument.type
count: 1
path: src/lib/RichText/XMLSanitizer.php
6 changes: 0 additions & 6 deletions ignore-gte-php8.1-errors.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ parameters:
count: 1
path: src/lib/RichText/TextExtractor/FullTextExtractor.php

-
message: '#^Parameter \#2 \$child of method DOMNode\:\:replaceChild\(\) expects TNode of DOMNode, DOMNameSpaceNode\|DOMNode given\.$#'
identifier: argument.type
count: 1
path: src/lib/RichText/XMLSanitizer.php

-
message: '#^Cannot call method removeChild\(\) on DOMNode\|null\.$#'
identifier: method.nonObject
Expand Down
2 changes: 1 addition & 1 deletion ignore-lte-php7.4-errors.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parameters:
ignoreErrors:
-
message: "#^Parameter \\#1 \\$string of function substr expects string, string\\|false\\|null given\\.$#"
message: "#^Parameter \\#1 \\$string of function substr expects string, string\\|false given\\.$#"
count: 2
path: src/lib/RichText/Converter/Render/Embed.php

Expand Down
84 changes: 84 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,42 @@ parameters:
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 1 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\?\: string, 2\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 1 might not exist on array\{\}\|list\{0\: string, 1\?\: ''''\|''ezremote\://'', 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 2 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\?\: string, 2\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 2 might not exist on array\{\}\|list\{0\: string, 1\?\: ''''\|''ezremote\://'', 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 2
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 2 might not exist on list\{0\: string, 1\: ''ezremote\://'', 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Offset 3 might not exist on array\{\}\|list\{0\: string, 1\?\: ''''\|''ezremote\://'', 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/FieldType/RichText/RichTextStorage.php

-
message: '#^Parameter \#1 \$source of method DOMDocument\:\:loadXML\(\) expects string, array\|bool\|float\|int\|string\|null given\.$#'
identifier: argument.type
Expand Down Expand Up @@ -756,6 +792,24 @@ parameters:
count: 1
path: src/lib/RichText/Converter/Link.php

-
message: '#^Offset 1 might not exist on array\{\}\|list\{0\: string, 1\?\: string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Converter/Link.php

-
message: '#^Offset 2 might not exist on array\{\}\|list\{0\: string, 1\?\: string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Converter/Link.php

-
message: '#^Offset 3 might not exist on array\{\}\|list\{0\: string, 1\?\: string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Converter/Link.php

-
message: '#^Parameter \#1 \$locationId of method Ibexa\\Contracts\\Core\\Repository\\LocationService\:\:loadLocation\(\) expects int, int\|null given\.$#'
identifier: argument.type
Expand Down Expand Up @@ -936,6 +990,12 @@ parameters:
count: 1
path: src/lib/RichText/Converter/Render/Embed.php

-
message: '#^Offset 1 might not exist on array\{\}\|array\{non\-falsy\-string, ''ezcontent''\|''ezlocation'', numeric\-string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Converter/Render/Embed.php

-
message: '#^PHPDoc tag @var has invalid value \(\$embed \\DOMElement\)\: Unexpected token "\$embed", expected type at offset 9 on line 1$#'
identifier: phpDoc.parseError
Expand Down Expand Up @@ -1146,6 +1206,18 @@ parameters:
count: 1
path: src/lib/RichText/RelationProcessor.php

-
message: '#^Offset 1 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\: non\-empty\-string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/RelationProcessor.php

-
message: '#^Offset 2 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\: non\-empty\-string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/RelationProcessor.php

-
message: '#^Cannot call method error\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
Expand Down Expand Up @@ -1278,6 +1350,18 @@ parameters:
count: 1
path: src/lib/RichText/Validator/InternalLinkValidator.php

-
message: '#^Offset 1 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\: non\-empty\-string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Validator/InternalLinkValidator.php

-
message: '#^Offset 2 might not exist on array\{\}\|list\{0\: non\-falsy\-string, 1\: non\-empty\-string, 2\?\: string, 3\?\: string\}\.$#'
identifier: offsetAccess.notFound
count: 1
path: src/lib/RichText/Validator/InternalLinkValidator.php

-
message: '#^PHPDoc tag @var has invalid value \(\\Ibexa\\Contracts\\Core\\Persistence\\Content\\Location\\Handler;\)\: Unexpected token ";", expected TOKEN_HORIZONTAL_WS at offset 74 on line 2$#'
identifier: phpDoc.parseError
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/CKEditor/custom-tags/ui/custom-tag-form-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class IbexaCustomTagFormView extends View {
}

setBooleanValue(attributeView, value) {
attributeView.fieldView.isOn = !!value || value === 'true';
attributeView.fieldView.isOn = value === 'true';
attributeView.fieldView.element.value = value;
attributeView.fieldView.set('value', value);
attributeView.fieldView.set('isEmpty', false);
Expand Down
Loading