-
Notifications
You must be signed in to change notification settings - Fork 231
custom builtin previewer #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom builtin previewer #2501
Conversation
phanen
commented
Jan 5, 2026
- fix: some error when custom picker
- fix: detect filetype from content when no filename is given
f64a823 to
b7f887e
Compare
|
not sure if my commit related to the failure. will see it later. |
2b9b1df to
16dbabc
Compare
|
dbfab99 to
03ab3a7
Compare
|
no better idea to fix, I just remove feedkey now. |
4a45754 to
3a97668
Compare
|
I see this will also close #2034. btw, doesn’t seem like |
3a97668 to
7c37e46
Compare
That still fail non-nightly test. Now only remove feedkey on nightly. |
7c37e46 to
f5169a1
Compare
|
Now that CI is fixed on nightly is this ready to be merged or you need more time? |
f5169a1 to
d459ec7
Compare
* error when fail to generate cache key * error when fail to get title string
modeline, shebang, some regex pattern in diff pattern, etc.
31206ec to
f88d164
Compare
|
fix some lint. |
You feel this is ready to be merged? I won’t be able to properly test and merge this in a couple of days as traveling, aiming to merge this Thursday |
|
Yeah, if it have issue i can fix it quickly. |
Alright I’ll merge it then, the start insert commit fixes #1659 (comment). |
fd242bc to
a7ba16d
Compare
a7ba16d to
2150452
Compare
not sure what this commit does, but I think this commit won't change the behavior ibhagwan@383e605
micro optimize
window-local winblend won't change in other buffer
41d0827 to
c83a02a
Compare
|
The latest 2 commit was to fix some window option issue. (just lazy to open another pr as usual...). |
|
preview window still use "global" option, which means it will be inherit by new split window, and switched buffer. since it has issue like #2266. Maybe this can also be fixed, but it's unusual to split a window from previewer, so let it as is. |
e9cfd23 to
386d0a8
Compare
preview window still use "global" option, which means it will be inherit by new split window, and switched buffer. since it has issue like ibhagwan#2266 Maybe this can also be fixed, but it's unusual to split a window from previewer, so let it as is.
386d0a8 to
a939149
Compare
|
Thank you @phanen for these great changes. Regarding the commit 383e605, say we had a complex regex in live grep and there are some discrepencies between the rg regex and For example say we search for This is also somewhat of a legacy since this is how live grep highlighting worked before the regex matching: cursor line to focus on the correct line, cursor char to focus on the right column. |