Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug that caused FzfLua global to fail with a nil value error when invoked from the command line. The fix involves extending the configuration normalization mechanism to correctly interpret and apply global settings for 'git' and 'dap' related modules, preventing the 'picker_opts' variable from being nil and ensuring stable operation of the global command. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
I have these config in cli |
There was a problem hiding this comment.
Code Review
This pull request fixes a crash in FzfLua global when using pickers with prefixes like git_ or dap_. The change correctly converts these prefixes to the format expected by the configuration system. My review includes a suggestion to make the implementation more concise by using a single gsub call with a capture group instead of chaining multiple calls.
I didn't think someone would ever need global in the cli |
FzfLua globalerror on cli