fix: forward ops.First.include_null when translating to FirstValue in window functions #11311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… window functions
github-actions
bot
added
tests
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Jun 6, 2025
Do not replace first() with first_value() because, per https://duckdb.org/docs/stable/sql/functions/window_functions#aggregate-window-functions The first and last aggregate functions are shadowed by the respective general-purpose window functions, with the minor consequence that the FILTER clause is not available for these but IGNORE NULLS is. After this change, the generated SQL is more canonical, and include_null actually works. This probably should wait until ibis-project#11311 lands, which has the tests for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
t.mutate(t.x.first(ignore_nulls=True).over(group_by=y))would behave the same ast.mutate(t.x.first(ignore_nulls=False).over(group_by=y)). Now they behave differently for some backends.I discovered this when implementing #11308
I am seeing what CI says before updating the tests/implementation for the other backends