fdasd: Add non-interactive script friendly interface#195
Draft
vojtechtrefny wants to merge 6 commits intoibm-s390-linux:masterfrom
Draft
fdasd: Add non-interactive script friendly interface#195vojtechtrefny wants to merge 6 commits intoibm-s390-linux:masterfrom
vojtechtrefny wants to merge 6 commits intoibm-s390-linux:masterfrom
Conversation
Member
|
Hey, this sounds good.I had a quick glance looks good. I know this is just an early draft, but for the real deal please split up the patch into multiple and first do all the refactoring (e.g. move stuff to separate functions) ans then the actual feature addition.| I am not soo fluent with the dasd tools but you may be able to reuse the CLI parser to parse you script. @hoeppnerj may provide more information and/or feedback |
Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
This splits the add partition functionality into two functions so the part that doesn't require user input can be reused. Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
This splits the remove partition functionality into two functions so the part that doesn't require user input can be reused. Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
This is a work-in-progress implementation of scripting interface similar to how 'parted --script' works, for now limited to adding and removing partitions only. Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
vojtechtrefny
force-pushed
the
master_fdasd-script-mode-3
branch
from
72bb0e6 to
af94f44
Compare
Author
|
I've pushed a new version. It's split into multiple commits, now includes the missing commands (like changing partition type), man page update and a simple (non-automated) test script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a work in progress patch, mostly giving you a chance to tell me you are not interested in this and/or suggest a better approach.
The idea is to provide a script friendly interface similar to
parted --script. Calling this can look for example liketo remove an existing partition and add a new 100 MiB one.
I am trying to reuse as much of the existing code as possible so this hopefully shouldn't create more maintenance work in the future.
This is obviously missing other commands, documentation and needs some more testing etc, as I said, still work in progress and mostly looking for some early feedback now.