Replace GetTagsUsingCRN with GetGlobalTagsUsingCRN (IBM-Cloud#6248)

We were calling each of these functions about half
and half, but they do literally the same thing. We
should be calling only one of them for consistency
and clarity.

Author: ismirlia

ibm/service/power/data_source_ibm_pi_hosts.go

@@ -163,7 +163,7 @@ func dataSourceIBMPIHostsRead(ctx context.Context, d *schema.ResourceData, meta
 			}
 			if host.Crn != "" {
 				hs[Attr_CRN] = host.Crn
-				tags, err := flex.GetTagsUsingCRN(meta, string(host.Crn))
+				tags, err := flex.GetGlobalTagsUsingCRN(meta, string(host.Crn), "", UserTagType)
 				if err != nil {
 					log.Printf("Error on get of pi host (%s) user_tags: %s", host.ID, err)
 				}

ibm/service/power/data_source_ibm_pi_image.go

@@ -113,7 +113,7 @@ func dataSourceIBMPIImagesRead(ctx context.Context, d *schema.ResourceData, meta
 	d.Set(Attr_Architecture, imagedata.Specifications.Architecture)
 	if imagedata.Crn != "" {
 		d.Set(Attr_CRN, imagedata.Crn)
-		tags, err := flex.GetTagsUsingCRN(meta, string(imagedata.Crn))
+		tags, err := flex.GetGlobalTagsUsingCRN(meta, string(imagedata.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi image (%s) user_tags: %s", *imagedata.ImageID, err)
 		}

ibm/service/power/data_source_ibm_pi_images.go

@@ -132,7 +132,7 @@ func flattenStockImages(list []*models.ImageReference, meta interface{}) []map[s
 		}
 		if i.Crn != "" {
 			l[Attr_CRN] = i.Crn
-			tags, err := flex.GetTagsUsingCRN(meta, string(i.Crn))
+			tags, err := flex.GetGlobalTagsUsingCRN(meta, string(i.Crn), "", UserTagType)
 			if err != nil {
 				log.Printf(
 					"Error on get of image (%s) user_tags: %s", *i.ImageID, err)

ibm/service/power/data_source_ibm_pi_network_address_group.go

@@ -91,7 +91,7 @@ func dataSourceIBMPINetworkAddressGroupRead(ctx context.Context, d *schema.Resou
 	d.SetId(*networkAddressGroup.ID)
 	if networkAddressGroup.Crn != nil {
 		d.Set(Attr_CRN, networkAddressGroup.Crn)
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*networkAddressGroup.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*networkAddressGroup.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi network address group (%s) user_tags: %s", nagID, err)
 		}

ibm/service/power/data_source_ibm_pi_network_address_groups.go

@@ -117,7 +117,7 @@ func networkAddressGroupsNetworkAddressGroupToMap(networkAddressGroup *models.Ne
 	nag := make(map[string]interface{})
 	if networkAddressGroup.Crn != nil {
 		nag[Attr_CRN] = networkAddressGroup.Crn
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*networkAddressGroup.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*networkAddressGroup.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi network address group (%s) user_tags: %s", *networkAddressGroup.ID, err)
 		}

ibm/service/power/data_source_ibm_pi_network_interface.go

@@ -148,7 +148,7 @@ func dataSourceIBMPINetworkInterfaceRead(ctx context.Context, d *schema.Resource
 	d.Set(Attr_Status, networkInterface.Status)
 	if networkInterface.Crn != nil {
 		d.Set(Attr_CRN, networkInterface.Crn)
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*networkInterface.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*networkInterface.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of network interface (%s) user_tags: %s", *networkInterface.ID, err)
 		}

ibm/service/power/data_source_ibm_pi_network_interfaces.go

@@ -163,7 +163,7 @@ func networkInterfaceToMap(netInterface *models.NetworkInterface, meta interface
 	interfaceMap[Attr_Status] = netInterface.Status
 	if netInterface.Crn != nil {
 		interfaceMap[Attr_CRN] = netInterface.Crn
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*netInterface.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*netInterface.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of network interface (%s) user_tags: %s", *netInterface.ID, err)
 		}

ibm/service/power/data_source_ibm_pi_network_security_group.go

@@ -222,7 +222,7 @@ func dataSourceIBMPINetworkSecurityGroupRead(ctx context.Context, d *schema.Reso
 	d.SetId(*networkSecurityGroup.ID)
 	if networkSecurityGroup.Crn != nil {
 		d.Set(Attr_CRN, networkSecurityGroup.Crn)
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*networkSecurityGroup.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*networkSecurityGroup.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi network security group (%s) user_tags: %s", *networkSecurityGroup.ID, err)
 		}

ibm/service/power/data_source_ibm_pi_network_security_groups.go

@@ -247,7 +247,7 @@ func networkSecurityGroupToMap(nsg *models.NetworkSecurityGroup, meta interface{
 	networkSecurityGroup := make(map[string]interface{})
 	if nsg.Crn != nil {
 		networkSecurityGroup[Attr_CRN] = nsg.Crn
-		userTags, err := flex.GetTagsUsingCRN(meta, string(*nsg.Crn))
+		userTags, err := flex.GetGlobalTagsUsingCRN(meta, string(*nsg.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi network security group (%s) user_tags: %s", *nsg.ID, err)
 		}

ibm/service/power/data_source_ibm_pi_volume.go

@@ -182,7 +182,7 @@ func dataSourceIBMPIVolumeRead(ctx context.Context, d *schema.ResourceData, meta
 	d.Set(Attr_CreationDate, volumedata.CreationDate.String())
 	if volumedata.Crn != "" {
 		d.Set(Attr_CRN, volumedata.Crn)
-		tags, err := flex.GetTagsUsingCRN(meta, string(volumedata.Crn))
+		tags, err := flex.GetGlobalTagsUsingCRN(meta, string(volumedata.Crn), "", UserTagType)
 		if err != nil {
 			log.Printf("Error on get of pi volume (%s) user_tags: %s", *volumedata.VolumeID, err)
 		}