Skip to content

Commit 90f7c69

Browse files
committed
Merge branch 'master' into it-template-source
2 parents d2d7ee2 + 896c4d1 commit 90f7c69

22 files changed

+61
-65
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ require (
1515
github.com/IBM/configuration-aggregator-go-sdk v0.0.2
1616
github.com/IBM/container-registry-go-sdk v1.1.0
1717
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2
18-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0
18+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0
1919
github.com/IBM/eventstreams-go-sdk v1.4.0
2020
github.com/IBM/go-sdk-core/v5 v5.20.1
2121
github.com/IBM/ibm-backup-recovery-sdk-go v1.0.3

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ github.com/IBM/container-registry-go-sdk v1.1.0 h1:sYyknIod8R4RJZQqAheiduP6wbSTp
116116
github.com/IBM/container-registry-go-sdk v1.1.0/go.mod h1:4TwsCnQtVfZ4Vkapy/KPvQBKFc3VOyUZYkwRU4FTPrs=
117117
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2 h1:yCJJnSLNYkpF7v9n0tw8CpQbSy43E/NbFOopRf1PgoM=
118118
github.com/IBM/continuous-delivery-go-sdk/v2 v2.0.2/go.mod h1:2MajFr6C5H2jyj7qtjBxAPnZAjbPiK4CAJNk3fKNnPo=
119-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0 h1:J6sUsEqZ5FVSLxaqrXOVGmqdPxCaHN9ujoRjXN2rdFQ=
120-
github.com/IBM/event-notifications-go-admin-sdk v0.14.0/go.mod h1:jhDfWFpQ7NhVWhgr2KSCIoWz32k0jur6Lde7LvvLODc=
119+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0 h1:5rmEbZmGhJiS+WZOK+ABp83nXmlIG5nLL0b1dCswO1Y=
120+
github.com/IBM/event-notifications-go-admin-sdk v0.15.0/go.mod h1:9fG6k1gYRqiChZvmn1iRIjaKCXuDBCOlPH6xPJN+mMU=
121121
github.com/IBM/eventstreams-go-sdk v1.4.0 h1:yS/Ns29sBOe8W2tynQmz9HTKqQZ0ckse4Py5Oy/F2rM=
122122
github.com/IBM/eventstreams-go-sdk v1.4.0/go.mod h1:2tuAxaYLctfqfr5jvyqSrxxEQGMwYPm3yJGWSj85YVQ=
123123
github.com/IBM/go-sdk-core/v5 v5.0.0/go.mod h1:vyNdbFujJtdTj9HbihtvKwwS3k/GKSKpOx9ZIQ6MWDY=

ibm/service/eventnotification/data_source_ibm_en_destination_pagerduty_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ func testAccCheckIBMEnPagerDutyDestinationDataSourceConfigBasic(instanceName, na
5555
config {
5656
params {
5757
routing_key = "33220320pgdpgpewwp"
58-
api_key = "dwvdouqufqwojji"
5958
}
6059
}
6160
}

ibm/service/eventnotification/resource_ibm_en_destination_pagerduty.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ func ResourceIBMEnPagerDutyDestination() *schema.Resource {
6868
Type: schema.TypeString,
6969
Sensitive: true,
7070
Optional: true,
71-
Default: "",
7271
Description: "API Key for the PagerDuty account.",
7372
Deprecated: "The api_key parameter under config has been deprecated and will be removed in future",
7473
},

ibm/service/eventnotification/resource_ibm_en_destination_pagerduty_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ func testAccCheckIBMEnPagerDutyDestinationConfig(instanceName, name, description
7676
config {
7777
params {
7878
routing_key = "33220320pgdpgpewwp"
79-
api_key = "dwvdouqufqwojji"
8079
}
8180
}
8281
}

ibm/service/eventnotification/resource_ibm_en_topic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func ResourceIBMEnTopic() *schema.Resource {
9090
},
9191
"ends_at": {
9292
Type: schema.TypeString,
93-
Required: true,
93+
Optional: true,
9494
Description: "event schedule end time.",
9595
},
9696
"expression": {

ibm/service/transitgateway/data_source_ibm_tg_connection_prefix_filter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
package transitgateway
55

66
import (
7-
"fmt"
7+
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex"
88
"github.com/IBM/networking-go-sdk/transitgatewayapisv1"
99
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1010
)
@@ -88,7 +88,7 @@ func dataSourceIBMTransitGatewayConnectionPrefixFilterRead(d *schema.ResourceDat
8888
getTransitGatewayConnectionPrefixFilterOptionsModel.SetFilterID(filterId)
8989
prefixFilter, response, err := client.GetTransitGatewayConnectionPrefixFilter(getTransitGatewayConnectionPrefixFilterOptionsModel)
9090
if err != nil {
91-
return fmt.Errorf("Error retrieving transit gateway connection prefix filter (%s): %s\n%s", filterId, err, response)
91+
return flex.FmtErrorf("Error retrieving transit gateway connection prefix filter (%s): %s\n%s", filterId, err, response)
9292
}
9393

9494
d.SetId(*prefixFilter.ID)

ibm/service/transitgateway/data_source_ibm_tg_connection_prefix_filters.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44
package transitgateway
55

66
import (
7-
"fmt"
7+
"time"
8+
9+
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex"
810
"github.com/IBM/networking-go-sdk/transitgatewayapisv1"
911
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
10-
"time"
1112
)
1213

1314
const (
@@ -100,7 +101,7 @@ func dataSourceIBMTransitGatewayConnectionPrefixFiltersRead(d *schema.ResourceDa
100101
listTransitGatewayConnectionPrefixFiltersOptionsModel.SetID(connectionId)
101102
listPrefixFilters, response, err := client.ListTransitGatewayConnectionPrefixFilters(listTransitGatewayConnectionPrefixFiltersOptionsModel)
102103
if err != nil {
103-
return fmt.Errorf("Error while listing transit gateway connection prefix filters %s\n%s", err, response)
104+
return flex.FmtErrorf("Error while listing transit gateway connection prefix filters %s\n%s", err, response)
104105
}
105106

106107
prefixFiltersCollection := make([]map[string]interface{}, 0)

ibm/service/transitgateway/data_source_ibm_tg_gateway.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
package transitgateway
55

66
import (
7-
"fmt"
87
"log"
98

109
"github.com/IBM/networking-go-sdk/transitgatewayapisv1"
@@ -236,7 +235,7 @@ func dataSourceIBMTransitGatewayRead(d *schema.ResourceData, meta interface{}) e
236235
listTransitGatewaysOptionsModel := &transitgatewayapisv1.ListTransitGatewaysOptions{}
237236
listTransitGateways, response, err := client.ListTransitGateways(listTransitGatewaysOptionsModel)
238237
if err != nil {
239-
return fmt.Errorf("[ERROR] Error while listing transit gateways %s\n%s", err, response)
238+
return flex.FmtErrorf("[ERROR] Error while listing transit gateways %s\n%s", err, response)
240239
}
241240

242241
gwName := d.Get(tgName).(string)
@@ -265,7 +264,7 @@ func dataSourceIBMTransitGatewayRead(d *schema.ResourceData, meta interface{}) e
265264
}
266265

267266
if !foundGateway {
268-
return fmt.Errorf("[ERROR] Couldn't find any gateway with the specified name: (%s)", gwName)
267+
return flex.FmtErrorf("[ERROR] Couldn't find any gateway with the specified name: (%s)", gwName)
269268
}
270269

271270
return dataSourceIBMTransitGatewayConnectionsRead(d, meta)
@@ -291,7 +290,7 @@ func dataSourceIBMTransitGatewayConnectionsRead(d *schema.ResourceData, meta int
291290
}
292291
listTGConnections, response, err := client.ListTransitGatewayConnections(listTransitGatewayConnectionsOptions)
293292
if err != nil {
294-
return fmt.Errorf("[ERROR] Error while listing transit gateway connections %s\n%s", err, response)
293+
return flex.FmtErrorf("[ERROR] Error while listing transit gateway connections %s\n%s", err, response)
295294
}
296295
for _, instance := range listTGConnections.Connections {
297296
tgConn := map[string]interface{}{}

ibm/service/transitgateway/data_source_ibm_tg_gateways.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
package transitgateway
55

66
import (
7-
"fmt"
87
"time"
98

9+
"github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex"
1010
"github.com/IBM/networking-go-sdk/transitgatewayapisv1"
1111
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1212
)
@@ -75,7 +75,7 @@ func dataSourceIBMTransitGatewaysRead(d *schema.ResourceData, meta interface{})
7575
listTransitGatewaysOptionsModel := &transitgatewayapisv1.ListTransitGatewaysOptions{}
7676
listTransitGateways, response, err := client.ListTransitGateways(listTransitGatewaysOptionsModel)
7777
if err != nil {
78-
return fmt.Errorf("[ERROR] Error while listing transit gateways %s\n%s", err, response)
78+
return flex.FmtErrorf("[ERROR] Error while listing transit gateways %s\n%s", err, response)
7979
}
8080

8181
tgws := make([]map[string]interface{}, 0)

0 commit comments

Comments
 (0)