feat(ppnlb): Add support for Reserved IP as member target of PPNLB #412
Conversation
keerthi-gp
changed the title
keerthi-gp
force-pushed
the
UI-40655-PPNLB-Reserved-IP
branch
from
211c2fc to
1d9cd1c
Compare
scripts/build.sh
Outdated
| echo "==> Packaging..." | ||
| for PLATFORM in $(find ./pkg -mindepth 1 -maxdepth 1 -type d); do | ||
| OSARCH=$(basename ${PLATFORM}) | ||
| ZIPNAME="terraform-provider-ibm_${VERSION}_${OSARCH}" |
There was a problem hiding this comment.
same, this file needs to be restored to master. This is just change to have the version in the binary generated
There was a problem hiding this comment.
revert this change
There was a problem hiding this comment.
As mentioned #414 doc needs to be changed in alphanumaric format and also attach the test results in the PR..
make testacc TEST=./ibm/service/vpc TESTARGS='-run='
to run acceptance test and also attach the results in the PR
Also Upload Binary to Artifactory and inform CSI team once you have tested in staging env
https://github.com/ibm-vpc/terraform-provider-ibm/wiki/Upload-Binary-to-Artifactory
Otherwise PR looks good to me.
|
keerthigp@Keerthis-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic_network_target_reservedIP' — PASS: TestAccIBMISLBPoolMember_basic_network_target_reservedIP (324.07s) keerthigp@Keerthis-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBProfileDatasource_basic' --- PASS: TestAccIBMISLBProfileDatasource_basic (18.24s) keerthigp@Keerthis-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBProfilesDatasource_basic' --- PASS: TestAccIBMISLBProfilesDatasource_basic (22.67s) keerthigp@Keerthis-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBProfilesDatasource_filter' --- PASS: TestAccIBMISLBProfilesDatasource_filter (20.06s) |
keerthi-gp
force-pushed
the
UI-40655-PPNLB-Reserved-IP
branch
from
c13f17f to
26ec8b0
Compare
No description provided.