feat(security-group-rule-name):adding optional name for security group rule name. #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uibm
requested changes
Sep 3, 2025
| - `local` - (String) The local IP address or range of local IP addresses to which this rule will allow inbound traffic (or from which, for outbound traffic). A CIDR block of 0.0.0.0/0 allows traffic to all local IP addresses (or from all local IP addresses, for outbound rules). an IP address, a `CIDR` block. | ||
| - `ip_version` - (Optional, String) The IP version to enforce. The format of local.address, remote.address, local.cidr_block or remote.cidr_block must match this property, if they are used. If remote references a security group, then this rule only applies to IP addresses (network interfaces) in that group matching this IP version. Supported value is [`ipv4`]. | ||
| - `icmp` - (Optional, List) A nested block describes the `icmp` protocol of this security group rule. | ||
| - `name` - (String) The name for this security group rule. The name must not be used by another rule in the security group. |
Collaborator
There was a problem hiding this comment.
it should be optional as well ?
| -arch="${XC_ARCH}" \ | ||
| -osarch="${XC_EXCLUDE_OSARCH}" \ | ||
| -ldflags "${LD_FLAGS}" \ | ||
| -output "pkg/{{.OS}}_{{.Arch}}/terraform-provider-ibm" \ |
| isVPCSecurityGroupRuleRemote = "remote" | ||
| isVPCSecurityGroupRuleType = "type" | ||
| isVPCSecurityGroupRuleCode = "code" | ||
| isVPCSecurityGroupRuleName = "name" |
Collaborator
There was a problem hiding this comment.
this has no code changes for rule name ?
| Computed: true, | ||
| }, | ||
|
|
||
| isVPCSecurityGroupRuleName: { |
| if securityGroupRule.Code != nil { | ||
| icmpProtocol["code"] = *securityGroupRule.Code | ||
| } | ||
| if securityGroupRule.Name != nil { |
Collaborator
There was a problem hiding this comment.
why is rule name set to protocol ?
shreyasms07
force-pushed
the
security-group-rule-name
branch
from
4b70c7b to
c4e3c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: