Skip to content

Harden stunredis.sh by not using a local TCP port #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Harden stunredis.sh by not using a local TCP port #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dcdbe6
Harden strunredis.sh by not using a local TCP port
tw-bert Feb 27, 2019
215781d
Small addendum - clean up UDS filename
tw-bert Feb 27, 2019
28a2faa
Restored Redis AUTH support, stripped accidentally
tw-bert Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stunredis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# limitations under the License.

DATABASE_URL=$1
LOCALPORT=${2:-6830}
REMOTEPORT=${2:-6830}

# This is the location of the validation chain file
lechain=./lechain.pem
Expand All @@ -32,8 +32,10 @@ userpass="`echo $url | grep @ | cut -d@ -f1`"
pass=`echo $userpass | grep : | cut -d: -f2`
if [ -n "$pass" ]; then
user=`echo $userpass | grep : | cut -d: -f1`
AUTH=" -a ${pass}"
else
user=$userpass
AUTH=""
fi
hostport=`echo $url | sed -e s,$userpass@,,g | cut -d/ -f1`
port=`echo $hostport | grep : | cut -d: -f2`
Expand All @@ -48,7 +50,7 @@ stunnelconf=""
stunnelconf+=$"foreground=yes\n"
stunnelconf+=$"[redis-cli]\n"
stunnelconf+=$"client=yes\n"
stunnelconf+=$"accept=127.0.0.1:$LOCALPORT\n"
stunnelconf+=$"accept=${HOME}/${host}.${REMOTEPORT}.${BASHPID}.sock\n"
stunnelconf+=$"verifyChain=yes\n"
stunnelconf+=$"checkHost=$host\n"
stunnelconf+=$"CAfile=$lechain\n"
Expand All @@ -65,8 +67,6 @@ stunnelpid=$!
# Sleep a moment to let the connection establish
sleep 1
# Now call redis-cli for the user to interact with
redis-cli -p $LOCALPORT -a ${pass}
redis-cli ${AUTH} -s ${HOME}/${host}.${REMOTEPORT}.${BASHPID}.sock
# Once they leave that, kill the stunnel
kill $stunnelpid