Support SecureRandom strong algorithms in FIPS mode#1187
Support SecureRandom strong algorithms in FIPS mode#1187Mohit-Rajbhar100698 wants to merge 1 commit intoibmruntimes:openj9from
Conversation
keithc-ca
left a comment
There was a problem hiding this comment.
Tests should be added to verify correct behavior of the new property, including that it can be appended in an profile extension.
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Show resolved
Hide resolved
0cfb409 to
6c583bb
Compare
I would also like to point out that tests for this feature already exist in JavaNext and in Java 26.
|
keithc-ca
left a comment
There was a problem hiding this comment.
Please also fix the commit message. Lines in the body should be no more than 72 characters long; see https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md#commit-guidelines.
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Show resolved
Hide resolved
|
Please explain how that existing test validates the new behavior added here. Yes, it tests that a strong |
37b59d8 to
930b1f3
Compare
|
Validating the behavior once manually is not what I was asking for. I think we need a new automated test that checks for proper operation. I suggest that new test belongs in |
67eb7f2 to
a7edcc1
Compare
2f95648 to
f3b87ce
Compare
This change overrides the default securerandom.strongAlgorithms configuration used by SecureRandom.getInstanceStrong() when it runs in FIPS mode. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
f3b87ce to
565a067
Compare


This change overrides the default securerandom.strongAlgorithms configuration used by SecureRandom.getInstanceStrong() when it runs in FIPS mode.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com