Merge pull request ceph#62252 from ronen-fr/wip-rf-fix-62188

idryomov · web-flow · commit 743c9d10a10d · 2025-03-13T20:42:27.000+01:00
librbd/ConfigWatcher: fix a missing 'override'

Reviewed-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
Reviewed-by: Patrick Donnelly &lt;pdonnell@ibm.com&gt;
diff --git a/src/librbd/ConfigWatcher.cc b/src/librbd/ConfigWatcher.cc
@@ -42,7 +42,7 @@ struct ConfigWatcher<I>::Observer : public md_config_obs_t {
     }
   }
 
-  std::vector<std::string> get_tracked_keys() const noexcept {
+  std::vector<std::string> get_tracked_keys() const noexcept override {
     return m_config_key_strs;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ struct ConfigWatcher<I>::Observer : public md_config_obs_t {`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`
`45`		`- std::vector<std::string> get_tracked_keys() const noexcept {`
	`45`	`+ std::vector<std::string> get_tracked_keys() const noexcept override {`
`46`	`46`	`return m_config_key_strs;`
`47`	`47`	`}`
`48`	`48`