Skip to content

Fix all the violations and warnings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-9.0
Choose a base branch
from
Open

Fix all the violations and warnings #29

wants to merge 1 commit into from

Conversation

rakshithakamath94
Copy link

No description provided.

@rakshithakamath94 rakshithakamath94 changed the base branch from main to release-9.0 September 3, 2025 18:57
@rakshithakamath94
Copy link
Author

/retest

@andrewschoen
Copy link
Member

Hi @rakshithakamath94, you'll need to set skip-checks back to true for both the pipelines to see the conforma checks. I had previously turned those off here: https://github.com/ibmstorage/rhceph-container/blob/release-9.0/.tekton/rhceph-container-9-0-pull-request.yaml#L39

@andrewschoen
Copy link
Member

Hi @rakshithakamath94, you'll need to set skip-checks back to true for both the pipelines to see the conforma checks. I had previously turned those off here: https://github.com/ibmstorage/rhceph-container/blob/release-9.0/.tekton/rhceph-container-9-0-pull-request.yaml#L39

actually, I went ahead and added back skip-checks to false in this commit. 15521a1

@rakshithakamath94
Copy link
Author

/retest

1 similar comment
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 2 times, most recently from b025643 to e6d05ae Compare September 4, 2025 13:06
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 3 times, most recently from c2e708d to 68513a2 Compare September 4, 2025 15:43
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 5 times, most recently from b34482d to 98fa334 Compare September 5, 2025 03:12
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 10 times, most recently from f1dfcb5 to f2e3b99 Compare September 5, 2025 16:10
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 5 times, most recently from 9821dcc to c3ff4bc Compare September 8, 2025 05:59
@rakshithakamath94
Copy link
Author

/retest

1 similar comment
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 3 times, most recently from 8f32ef6 to d6699ab Compare September 8, 2025 10:40
@rakshithakamath94
Copy link
Author

/retest

@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 5 times, most recently from 388c0fa to 0d6b8ad Compare September 8, 2025 13:29
@rakshithakamath94
Copy link
Author

/retest

1 similar comment
@rakshithakamath94
Copy link
Author

/retest

andrewschoen
andrewschoen requested changes Sep 24, 2025
View reviewed changes
Copy link
Member

@andrewschoen andrewschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I get my work in for rhel10 can you please rebase this to pull in the new rpms.repo, compose.repo and rpms.lock.yaml? We might have to finish up the rpm and compose related violations in another PR so that I can coordinate it with the container automation.

.tekton/rhceph-container-9-0-pull-request.yaml
"options": {
"dnf": {
"odcs-4414456": {
"rhceph-8-tools-for-rhel-9-x86_64-rpms": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get the rhceph-9-* repo ids created and allowed?

@andrewschoen andrewschoen mentioned this pull request Sep 29, 2025
Merged
@rakshithakamath94 rakshithakamath94 force-pushed the wip-konflux-release branch 2 times, most recently from 946c67d to 56cca83 Compare September 30, 2025 04:53
Fix all the violations and warnings
28f98e8 
Signed-off-by: Rakshitha-Kamath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewschoen andrewschoen andrewschoen requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakshithakamath94 @andrewschoen